vm wizard: add MAC Address validator - #657
Conversation
|
@rhtyd Also on the issue, @andrijapanicsb wants to see the IP range of the network, to be able to KNOW from which range to use an IP when specifying it explicitly down for the NIC attached to that network. Do you have any ideas? |
|
@utchoang in the network record if that's an isolated/shared network (or != L2 network) then you can check the [1] https://tech.mybuilder.com/determining-if-an-ipv4-address-is-within-a-cidr-range-in-javascript/ |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
|
@blueorangutan package |
|
@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
|
LGTM |
|
@blueorangutan package |
|
@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
|
@davidjumani please review this |
|
@davidjumani I've fixed it. Please review it again. Thanks. |
|
@blueorangutan package |
|
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️centos ✔️debian ✔️archive. |
davidjumani
left a comment
davidjumani
left a comment
There was a problem hiding this comment.
LGTM! Thanks @utchoang
@rhtyd Good to go!
* vm wizard: add MAC Address validator * show IP range and check valid IP range * add CIDR into expanding of network selection & configuration * hide element when network type !== L2
4 participants
Fixes #648
@rhtyd cc @svenvogel