Changing dependency from python3-distutils to python3-distutils-extra by davidjumani · Pull Request #4305 · apache/cloudstack

davidjumani · 2020-09-04T11:07:40Z

Description

Changing dependency from python3-distutils to python3-distutils-extra to continue supporting Ubuntu 16.04

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

davidjumani · 2020-09-04T11:07:54Z

@blueorangutan package

blueorangutan · 2020-09-04T11:36:12Z

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1892

blueorangutan · 2020-09-04T12:01:10Z

Packaging result: ✖centos7 ✖centos8 ✖debian. JID-1893

blueorangutan · 2020-09-04T14:09:51Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1894

davidjumani · 2020-09-04T14:20:47Z

Kicking tests manually

yadvr · 2020-09-05T19:08:33Z

Trillian fails to deploy env again u18 env:

20:24:59 TASK [kvm : Updated /etc/default/libvirt-bin in trusty] ************************
20:24:59 skipping: [pr4305-t2665-kvm-ubuntu-kvm1] => {"changed": false, "skip_reason": "Conditional result was False", "skipped": true}
20:24:59 skipping: [pr4305-t2665-kvm-ubuntu-kvm2] => {"changed": false, "skip_reason": "Conditional result was False", "skipped": true}
20:24:59 
20:24:59 TASK [kvm : Update /etc/default/libvirtd in bionic] ****************************
20:24:59 fatal: [pr4305-t2665-kvm-ubuntu-kvm2]: FAILED! => {"changed": false, "failed": true, "msg": "Destination /etc/default/libvirtd does not exist !", "rc": 257}
20:25:00 
20:25:00 msg: Destination /etc/default/libvirtd does not exist !
20:25:00 fatal: [pr4305-t2665-kvm-ubuntu-kvm1]: FAILED! => {"changed": false, "failed": true, "msg": "Destination /etc/default/libvirtd does not exist !", "rc": 257}
20:25:00

davidjumani · 2020-09-07T04:53:47Z

@rhtyd Looks like an unrelated issue. Will try kicking tests on 16 and then 18

Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

davidjumani · 2020-09-08T05:59:49Z

@blueorangutan package

blueorangutan · 2020-09-08T06:00:27Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-08T06:34:32Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-1915

yadvr · 2020-09-08T07:58:39Z

@davidjumani can you manually kick tests and see if that fixes the issue for Ubuntu 16.04 and passes on Ubuntu 18.04+ as well

davidjumani · 2020-09-09T04:33:39Z

@rhtyd The envs are sporadically failing while running tests. Kicking them again

davidjumani · 2020-09-15T11:38:43Z

Kicking tests again

shwstppr · 2020-09-15T11:57:23Z

@davidjumani will it be better to merge latest master first? There have been some fixes for ubuntu on master lately
Or rebuild the packages

blueorangutan · 2020-09-16T06:36:05Z

Trillian test result (tid-2748)
Environment: kvm-ubuntu18 (x2), Advanced Networking with Mgmt server u18
Total time taken: 65497 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4305-t2748-kvm-ubuntu18.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 81 look OK, 4 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_delete_kubernetes_supported_version	`Error`	1804.59	test_kubernetes_supported_versions.py
test_11_migrate_vm	`Error`	49.88	test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration	`Error`	129.61	test_vm_life_cycle.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	479.68	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	3954.98	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Failure`	443.88	test_vpc_redundant.py
test_disable_oobm_ha_state_ineligible	`Error`	1514.27	test_hostha_kvm.py

blueorangutan · 2020-09-17T06:23:06Z

Trillian test result (tid-2762)
Environment: kvm-ubuntu (x2), Advanced Networking with Mgmt server u
Total time taken: 51851 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4305-t2762-kvm-ubuntu.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_pvlan.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 77 look OK, 8 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_deploy_kubernetes_cluster	`Error`	0.10	test_kubernetes_clusters.py
test_02_deploy_kubernetes_ha_cluster	`Error`	0.06	test_kubernetes_clusters.py
test_04_deploy_and_upgrade_kubernetes_cluster	`Error`	0.06	test_kubernetes_clusters.py
test_05_deploy_and_upgrade_kubernetes_ha_cluster	`Error`	0.06	test_kubernetes_clusters.py
test_06_deploy_and_invalid_upgrade_kubernetes_cluster	`Error`	0.06	test_kubernetes_clusters.py
test_07_deploy_and_scale_kubernetes_cluster	`Error`	0.06	test_kubernetes_clusters.py
test_01_add_delete_kubernetes_supported_version	`Error`	1804.93	test_kubernetes_supported_versions.py
ContextSuite context=TestListIdsParams>:setup	`Error`	0.00	test_list_ids_parameter.py
test_02_vpc_privategw_static_routes	`Failure`	336.44	test_privategw_acl.py
test_create_pvlan_network	`Error`	0.06	test_pvlan.py
test_01_snapshot_root_disk	`Error`	5.46	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	21.61	test_snapshots.py
test_01_snapshot_usage	`Error`	15.68	test_usage.py
test_hostha_enable_ha_when_host_disabled	`Error`	1.57	test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	301.53	test_hostha_kvm.py

davidjumani · 2020-09-17T07:12:42Z

@blueorangutan package

blueorangutan · 2020-09-17T07:13:31Z

@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-17T07:47:55Z

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2026

blueorangutan · 2020-09-18T01:16:17Z

Trillian test result (tid-2768)
Environment: kvm-ubuntu (x2), Advanced Networking with Mgmt server u
Total time taken: 57788 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4305-t2768-kvm-ubuntu.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_pvlan.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 78 look OK, 7 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_01_add_delete_kubernetes_supported_version	`Error`	1805.60	test_kubernetes_supported_versions.py
ContextSuite context=TestListIdsParams>:setup	`Error`	0.00	test_list_ids_parameter.py
test_create_pvlan_network	`Error`	0.05	test_pvlan.py
test_01_snapshot_root_disk	`Error`	10.21	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	29.31	test_snapshots.py
test_01_snapshot_usage	`Error`	7.37	test_usage.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	`Failure`	461.93	test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics	`Error`	3897.41	test_vpc_redundant.py
test_hostha_kvm_host_fencing	`Error`	176.28	test_hostha_kvm.py

yadvr · 2020-09-21T08:45:02Z

@davidjumani ping, update?

davidjumani · 2020-09-22T03:58:50Z

@rhtyd Works fine on u20 and u18, snapshots are failing on u16. Looking into it

yadvr · 2020-09-22T12:14:40Z

Ignore snapshot failures on Ubuntu 16.04 which could be due to old libvirt/qemu-img binary. Other than that is the PR working and fixes the blocker?

yadvr · 2020-09-22T12:19:27Z

I think snapshot failure is a known issue on older distros with older libvirt and qemu-img; earlier snapshots were disabled by default if I recall correctly, there is a global setting to enable/disable snapshot feature on KVM.

yadvr · 2020-09-22T12:19:58Z

@davidjumani which test results are for Ubuntu 16.04? and which are for 18.04 and 20.04?

davidjumani · 2020-09-22T12:23:22Z

Trillian test result (tid-2768)
Environment: kvm-ubuntu (x2), Advanced Networking with Mgmt server u
Total time taken: 57788 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4305-t2768-kvm-ubuntu.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_list_ids_parameter.py
Intermittent failure detected: /marvin/tests/smoke/test_pvlan.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_router_dhcphosts.py
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_usage.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 78 look OK, 7 have error(s)
Only failed tests results shown below:
Test Result Time (s) Test File
test_01_add_delete_kubernetes_supported_version Error 1805.60 test_kubernetes_supported_versions.py
ContextSuite context=TestListIdsParams>:setup Error 0.00 test_list_ids_parameter.py
test_create_pvlan_network Error 0.05 test_pvlan.py
test_01_snapshot_root_disk Error 10.21 test_snapshots.py
test_02_list_snapshots_with_removed_data_store Error 29.31 test_snapshots.py
test_01_snapshot_usage Error 7.37 test_usage.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Failure 461.93 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Error 3897.41 test_vpc_redundant.py
test_hostha_kvm_host_fencing Error 176.28 test_hostha_kvm.py

@rhtyd u16

Trillian test result (tid-2748)
Environment: kvm-ubuntu18 (x2), Advanced Networking with Mgmt server u18
Total time taken: 65497 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4305-t2748-kvm-ubuntu18.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_supported_versions.py
Intermittent failure detected: /marvin/tests/smoke/test_templates.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 81 look OK, 4 have error(s)
Only failed tests results shown below:
Test Result Time (s) Test File
test_01_add_delete_kubernetes_supported_version Error 1804.59 test_kubernetes_supported_versions.py
test_11_migrate_vm Error 49.88 test_vm_life_cycle.py
test_14_secure_to_secure_vm_migration Error 129.61 test_vm_life_cycle.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Failure 479.68 test_vpc_redundant.py
test_04_rvpc_network_garbage_collector_nics Error 3954.98 test_vpc_redundant.py
test_05_rvpc_multi_tiers Failure 443.88 test_vpc_redundant.py
test_disable_oobm_ha_state_ineligible Error 1514.27 test_hostha_kvm.py

@rhtyd u18
U20 tested locally since lab is having issues bringing up the env. Will try again now

blueorangutan · 2020-09-22T13:29:26Z

Trillian test result (tid-2833)
Environment: kvm-ubuntu20 (x2), Advanced Networking with Mgmt server u20
Total time taken: 1570 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4305-t2833-kvm-ubuntu20.zip
Smoke tests completed. 0 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File

yadvr · 2020-09-23T08:53:34Z

tests LGTM

Pearl1594

LGTM

shwstppr

LGTM based on code changes and installation check on different Ubuntu releases

Changing dependency from python3-distutils to python3-distutils-extra

a15757a

davidjumani mentioned this pull request Sep 4, 2020

cloudstack-common no longer installed with cloudstack-agent and cloudstack-management #4280

Closed

shwstppr reviewed Sep 8, 2020

View reviewed changes

Comment thread debian/control Outdated

Update debian/control

5441b67

Co-authored-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

yadvr added this to the 4.15.0.0 milestone Sep 9, 2020

yadvr approved these changes Sep 22, 2020

View reviewed changes

yadvr requested a review from wido September 22, 2020 12:18

yadvr requested review from GabrielBrascher and weizhouapache September 22, 2020 12:18

yadvr marked this pull request as ready for review September 22, 2020 12:18

Pearl1594 approved these changes Sep 23, 2020

View reviewed changes

shwstppr approved these changes Sep 23, 2020

View reviewed changes

yadvr merged commit d657ef7 into apache:master Sep 23, 2020

DaanHoogland added the type:enhancement label Oct 21, 2020

Conversation

davidjumani commented Sep 4, 2020

Description

Types of changes

Uh oh!

davidjumani commented Sep 4, 2020

Uh oh!

blueorangutan commented Sep 4, 2020

Uh oh!

blueorangutan commented Sep 4, 2020

Uh oh!

blueorangutan commented Sep 4, 2020

Uh oh!

davidjumani commented Sep 4, 2020

Uh oh!

yadvr commented Sep 5, 2020

Uh oh!

davidjumani commented Sep 7, 2020

Uh oh!

Uh oh!

davidjumani commented Sep 8, 2020

Uh oh!

blueorangutan commented Sep 8, 2020

Uh oh!

blueorangutan commented Sep 8, 2020

Uh oh!

yadvr commented Sep 8, 2020

Uh oh!

davidjumani commented Sep 9, 2020

Uh oh!

davidjumani commented Sep 15, 2020

Uh oh!

shwstppr commented Sep 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Sep 16, 2020

Uh oh!

blueorangutan commented Sep 17, 2020

Uh oh!

davidjumani commented Sep 17, 2020

Uh oh!

blueorangutan commented Sep 17, 2020

Uh oh!

blueorangutan commented Sep 17, 2020

Uh oh!

blueorangutan commented Sep 18, 2020

Uh oh!

yadvr commented Sep 21, 2020

Uh oh!

davidjumani commented Sep 22, 2020

Uh oh!

yadvr commented Sep 22, 2020

Uh oh!

yadvr commented Sep 22, 2020

Uh oh!

yadvr commented Sep 22, 2020

Uh oh!

davidjumani commented Sep 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Sep 22, 2020

Uh oh!

yadvr commented Sep 23, 2020

Uh oh!

Pearl1594 left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

shwstppr commented Sep 15, 2020 •

edited

Loading

davidjumani commented Sep 22, 2020 •

edited

Loading