Skip to content

Trimming string api parameters and disallowing only space as an api parameter value #4311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidjumani wants to merge 1 commit into from
Closed

Trimming string api parameters and disallowing only space as an api parameter value #4311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions server/src/main/java/com/cloud/api/dispatch/ParamProcessWorker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ private void setFieldValue(final Field field, final BaseCmd cmdObj, final Object
final List listParam = new ArrayList();
final StringTokenizer st = new StringTokenizer(paramObj.toString(), ",");
while (st.hasMoreTokens()) {
final String token = st.nextToken();
final String token = st.nextToken().trim();
final CommandType listType = annotation.collectionType();
switch (listType) {
case INTEGER:
Expand Down Expand Up @@ -408,8 +408,13 @@ private void setFieldValue(final Field field, final BaseCmd cmdObj, final Object
if (paramObj.toString().length() > annotation.length()) {
s_logger.error("Value greater than max allowed length " + annotation.length() + " for param: " + field.getName());
throw new InvalidParameterValueException("Value greater than max allowed length " + annotation.length() + " for param: " + field.getName());
} else {
field.set(cmdObj, paramObj.toString());
} else{
String trimmedParam = paramObj.toString().trim();
if (trimmedParam.length() == 0){
s_logger.error("Empty string or only spaces are not allowed for " + field.getName());
throw new InvalidParameterValueException("Empty string or only spaces are not allowed for " + field.getName());
}
field.set(cmdObj, trimmedParam);
}
}
break;
Expand Down