Skip to content

Modify alter view to drop/create view - #4417

Merged
DaanHoogland merged 1 commit into
apache:masterfrom
shapeblue:sql_upgrade
Oct 28, 2020
Merged

DaanHoogland merged 1 commit into
apache:masterfrom
shapeblue:sql_upgrade

Conversation

@Pearl1594

@Pearl1594 Pearl1594 commented Oct 21, 2020

Copy link
Copy Markdown
Contributor

Description

As a best practice, it is better to drop and create a new view as opposed to altering a view. The PR addresses changing alter view to re-creation of the views after being dropped

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Run upgrade test:

  1. deployed a 4.14 setup
  2. Created some projects, added/invites a few users
  3. Upgraded to 4.15
  4. listed projects, project invitations to verify that they are still intact

@Pearl1594
Pearl1594 marked this pull request as draft October 21, 2020 13:54
@Pearl1594

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@Pearl1594

Copy link
Copy Markdown
Contributor Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2264

@Pearl1594

Copy link
Copy Markdown
Contributor Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@Pearl1594 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@Pearl1594
Pearl1594 marked this pull request as ready for review October 23, 2020 11:50

@harikrishna-patnala harikrishna-patnala left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaanHoogland DaanHoogland added this to the 4.15.0.0 milestone Oct 27, 2020
@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2284

@GabrielBrascher GabrielBrascher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

Trillian test result (tid-3088)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33571 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4417-t3088-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File

@DaanHoogland
DaanHoogland merged commit 25dd7aa into apache:master Oct 28, 2020
@DaanHoogland
DaanHoogland deleted the sql_upgrade branch October 28, 2020 08:53
@PaulAngus PaulAngus removed the type:bug label Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants