Check all mgt server connectivity

[ravening]

Description

Check all mgt server connectivity

Currently ssvm checks connectivity only for one mgt server.
Since we can have multiple mgt servers using comma separated
list, make the change in script so that it checks for connectivity
for all mgt servers

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Before the fix

root@s-172-VM:~# /usr/local/cloud/systemvm/ssvm-check.sh
================================================
Management server is 10.135.122.10,10.135.122.15,10.135.122.16. Checking connectivity.
ERROR: Cannot connect to 10.135.122.10,10.135.122.15,10.135.122.16 port 8250
2020/11/03 12:58:34 socat[4508] E parseopts(): unknown option "10.135.122.15" <<<<<<<<<<<<<<

After the fix

root@s-175-VM:~# /usr/local/cloud/systemvm/ssvm-check.sh
================================================
Management server is 10.135.122.10,10.135.122.15,10.135.122.16. Checking connectivity.
Good: Can connect to management server 10.135.122.10 port 8250
Good: Can connect to management server 10.135.122.15 port 8250
Good: Can connect to management server 10.135.122.16 port 8250
================================================
Tests Complete. Look for ERROR or WARNING above.

[DaanHoogland]

@ravening I'd call this a cleanup and not a bug would you? the check-ssvm script is not a runtime requirement but more like tooling, agree?

[DaanHoogland]

@PaulAngus @rhtyd this should/could go in even older versions than 4.15. not a runtime fix but a fix of the ssvm check script that will usually only run if the ssvm isn't working anyway.

[ravening]

@ravening I'd call this a cleanup and not a bug would you? the check-ssvm script is not a runtime requirement but more like tooling, agree?

@DaanHoogland fine with me 🙂 feel free to add proper label

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2360

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-3148)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35312 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4446-t3148-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_kubernetes_clusters.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 85 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_04_rvpc_privategw_static_routes	Failure	864.84	test_privategw_acl.py

[DaanHoogland]

@borisstoyanov @vladimirpetrov can you review/test?

[DaanHoogland]

not in production code, 2 lgtm, test results provided -> merging