Issue #7903 : Add find and replace to the explorer content editor - #7947
Open
mattcasters wants to merge 1 commit into
Open
Issue #7903 : Add find and replace to the explorer content editor#7947mattcasters wants to merge 1 commit into
mattcasters wants to merge 1 commit into
Conversation
Reuse FindReplaceDialog for BaseTextExplorerFileType tabs (open as text, YAML, SQL, XML, logs, markdown) via the shared content-editor toolbar and desktop popup menu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseTextExplorerFileType(Open as text, YAML, SQL, XML, logs, markdown).FindReplaceDialogontoIFindReplaceTargetso explorer tabs reuse the same dialog asTextComposite(next/previous, wrap, case sensitive, replace one/all).Text, and Monaco remote methods so toolbar actions work in both GUIs.Fixes #7903
Test plan
ui,rcp,rapFindReplaceOperationsTest,ContentEditorActionsTest,TextFindSupportTest,GuiPluginWebCompatibilityTest.hpl/.hwfas text: Find and Find/Replace on toolbar and popupTextCompositeFind / Replace still works