Skip to content

Issue #7903 : Add find and replace to the explorer content editor - #7947

Open
mattcasters wants to merge 1 commit into
apache:mainfrom
mattcasters:issue-7903
Open

Issue #7903 : Add find and replace to the explorer content editor#7947
mattcasters wants to merge 1 commit into
apache:mainfrom
mattcasters:issue-7903

Conversation

@mattcasters

Copy link
Copy Markdown
Contributor

Summary

  • Adds Find and Find/Replace to the shared content-editor toolbar and desktop popup used by BaseTextExplorerFileType (Open as text, YAML, SQL, XML, logs, markdown).
  • Generalizes FindReplaceDialog onto IFindReplaceTarget so explorer tabs reuse the same dialog as TextComposite (next/previous, wrap, case sensitive, replace one/all).
  • Implements selection/caret/insert on the desktop SourceViewer, Hop Web fallback Text, and Monaco remote methods so toolbar actions work in both GUIs.
  • Ctrl+F / Ctrl+H while the editor is focused open the local dialog; Hop GUI Edit → Find (Search Everywhere) is unchanged.

Fixes #7903

Test plan

  • Compile ui, rcp, rap
  • Unit tests: FindReplaceOperationsTest, ContentEditorActionsTest, TextFindSupportTest, GuiPluginWebCompatibilityTest
  • Spotless apply on changed modules
  • Open .hpl / .hwf as text: Find and Find/Replace on toolbar and popup
  • Find next/previous wraps and seeds from the current selection
  • Replace one / replace all marks the file dirty
  • Read-only / binary open-as-text: Find enabled, Replace disabled
  • YAML / SQL / XML / markdown tabs get the same buttons
  • Dialog TextComposite Find / Replace still works
  • Editor focused: Ctrl+F opens the local dialog; graph focused: Ctrl+F still opens Search Everywhere

Reuse FindReplaceDialog for BaseTextExplorerFileType tabs (open as text,
YAML, SQL, XML, logs, markdown) via the shared content-editor toolbar
and desktop popup menu.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Search feature in text view

1 participant