Add QUERY method caching support#846
Open
desiderantes wants to merge 1 commit into
Open
Conversation
desiderantes
force-pushed
the
desiderantes/query-caching
branch
from
d0f39b4 to
fb39582
Compare
ok2c
reviewed
Jul 15, 2026
| } | ||
| } | ||
| } | ||
| return null; |
Member
There was a problem hiding this comment.
@desiderantes I apologize it took me to long to get back to you.
Your approach is not unreasonable but it can still lead to cache entries with partial / broken keys, if the content body they are enclosing cannot be extracted. The key generator must always produce a valid key. This method must not return null.
What we need to do instead is to ensure those requests that cannot be correctly represented as SimpleHttpRequest get routed along the execution chain bypassing the caching layer.
Please as the first step review my pull request #850
Contributor
Author
There was a problem hiding this comment.
ok, yes, if null is not an option, this doesn't work. I'll take a look at that PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This part was dropped from #840 but I reworked it based on the feedback I got. Now CacheKeyGenerator is not a singleton but a regular class that can receive a body extraction function.