Repository navigation
fix(core): avoid pruning NaN values with column stats - #1022
Open
GayathriSrividya wants to merge 1 commit into
Open
GayathriSrividya wants to merge 1 commit into
GayathriSrividya wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #859
Description
Parquet omits NaN values from float min/max statistics, which can make Spark incorrectly skip files for matching predicates. Mark Float32/Float64 column ranges as unknown when they contain NaN, so those incomplete stats are not used to prune files. Writer paths inspect original batches rather than decoding newly written Parquet again.
How are the changes test-covered
Regression test:
./build-wrapper.sh cargo test -p hudi-core metadata::table::column_stats::tests::test_column_ranges_from_parquet_nan_values_are_not_prunable --lib— passed (1 passed, 1708 filtered out).