Skip to content

test(core): use the renamed metadata table toggle in the runtime test - #943

Closed
codope wants to merge 1 commit into
apache:mainfrom
codope:test/fix-with-metadata-rename
Closed

codope wants to merge 1 commit into
apache:mainfrom
codope:test/fix-with-metadata-rename

Conversation

@codope

@codope codope commented Oct 30, 2026

Copy link
Copy Markdown
Member

main no longer compiles its test targets:

error[E0599]: no method named `with_metadata` found for struct `TableCreateBuilder` in the current scope
  --> crates/core/tests/table_write_runtime_tests.rs:88:10

#884 added table_write_runtime_tests.rs calling TableCreateBuilder::with_metadata, and #927 renamed that method to with_metadata_table_enabled. Both merged on 2026-10-30 and each passed CI on its own branch, so the break only appeared once both were on main. Since then check-code, msrv-check and the Rust test jobs fail for every open PR (for example #767).

This renames the one remaining call. No other TableCreateBuilder::with_metadata callers are left; the other with_metadata calls in the tree are Arrow's Field::with_metadata.

How are the changes test-covered

  • N/A
  • Automated tests (unit and/or integration tests)
  • Manual tests
    • Details are described below

This is the fix to an existing test; make check-rust passes locally and cargo test -p hudi-core --test table_write_runtime_tests runs it green.

apache#884 added table_write_runtime_tests.rs calling TableCreateBuilder's
with_metadata, which apache#927 renamed to with_metadata_table_enabled. Each PR
passed CI on its own branch, so the test binary stopped compiling only
once both were on main, failing clippy and the Rust tests for every PR.

Signed-off-by: codope <sagarsumit09@gmail.com>
@codope
codope requested a review from xushiyan as a code owner October 30, 2026 18:23
@codope

codope commented Oct 30, 2026

Copy link
Copy Markdown
Member Author

@yihua this will fix CI failure on main. Please review.

@codope
codope requested a review from yihua October 30, 2026 18:27

@yihua yihua left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @codope , the fix is merged as part of #880.

@codope

codope commented Oct 30, 2026

Copy link
Copy Markdown
Member Author

Oh cool. I will close this. Thanks.

@codope codope closed this Oct 30, 2026
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.90%. Comparing base (54ce1fc) to head (d7d297f).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #943      +/-   ##
==========================================
+ Coverage   90.42%   90.90%   +0.48%     
==========================================
  Files         149      151       +2     
  Lines       20945    21283     +338     
==========================================
+ Hits        18939    19348     +409     
+ Misses       2006     1935      -71     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants