Repository navigation
Conversation
apache#884 added table_write_runtime_tests.rs calling TableCreateBuilder's with_metadata, which apache#927 renamed to with_metadata_table_enabled. Each PR passed CI on its own branch, so the test binary stopped compiling only once both were on main, failing clippy and the Rust tests for every PR. Signed-off-by: codope <sagarsumit09@gmail.com>
Member
Author
|
@yihua this will fix CI failure on main. Please review. |
Member
Author
|
Oh cool. I will close this. Thanks. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #943 +/- ##
==========================================
+ Coverage 90.42% 90.90% +0.48%
==========================================
Files 149 151 +2
Lines 20945 21283 +338
==========================================
+ Hits 18939 19348 +409
+ Misses 2006 1935 -71 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainno longer compiles its test targets:#884 added
table_write_runtime_tests.rscallingTableCreateBuilder::with_metadata, and #927 renamed that method towith_metadata_table_enabled. Both merged on 2026-10-30 and each passed CI on its own branch, so the break only appeared once both were onmain. Since thencheck-code,msrv-checkand the Rust test jobs fail for every open PR (for example #767).This renames the one remaining call. No other
TableCreateBuilder::with_metadatacallers are left; the otherwith_metadatacalls in the tree are Arrow'sField::with_metadata.How are the changes test-covered
This is the fix to an existing test;
make check-rustpasses locally andcargo test -p hudi-core --test table_write_runtime_testsruns it green.