Repository navigation
Conversation
…olumn stats Column-stats pruning read each candidate base file's footer one after another. A partition's footer reads now go out concurrently, bounded by hoodie.plan.listing.parallelism, and the retained file groups keep their input order.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #996 +/- ##
==========================================
+ Coverage 90.96% 90.97% +0.01%
==========================================
Files 154 154
Lines 22070 22073 +3
==========================================
+ Hits 20076 20081 +5
+ Misses 1994 1992 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #994
Column-stats pruning read each candidate base file's parquet footer one after another, so planning a filtered read over N files waited for N sequential round trips to storage. A partition's footer reads now go out concurrently, bounded by
hoodie.plan.listing.parallelism(the knob the partition listing already uses), and the retained file groups keep their input order. Partitions are still pruned one at a time, so the gain is largest for tables with many files per partition. The pruning decision for each file is unchanged.How are the changes test-covered
A new test counts footer reads in flight through the test-only counting object store and fails when the reads are serial. The existing footer-pruning tests cover the keep and prune decisions.