Repository navigation
Conversation
The global config file was read through the table's object store at its local path, so a table on cloud storage sent a GET for etc/hudi/conf/hudi-defaults.conf into its bucket on every open instead of reading the local file. Read it from the local filesystem, which also lets a relative HUDI_CONF_DIR work.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #997 +/- ##
==========================================
- Coverage 90.96% 90.94% -0.03%
==========================================
Files 154 154
Lines 22070 22068 -2
==========================================
- Hits 20076 20069 -7
- Misses 1994 1999 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #995
hudi-defaults.confwas read through the table's object store at its local path, so for a table on S3, GCS or Azure every table open sent a GET foretc/hudi/conf/hudi-defaults.confinto the table's bucket instead of reading the local file. It is now read from the local filesystem, which also makes a relativeHUDI_CONF_DIRwork. A file placed at that key in a table's bucket is no longer applied. hudi-core now enables tokio'sfsfeature.Impact: one request fewer per table open, so two fewer for a cold open and plan of a table with a metadata table (both tables are opened). In a request trace of a cold open and plan on a metadata-enabled test fixture, these were 2 of the 33 requests, each waiting on the one before.
How are the changes test-covered
A new test resolves options with a relative
HUDI_CONF_DIRand fails on the old read path. The existingget_global_table_propstest covers the absolute, missing and unset cases.