benchmark: add metrics evaluator benchmark#831
Open
timothyw553 wants to merge 1 commit into
Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds a focused benchmark for metrics evaluator performance now that the shared benchmark build scaffolding has landed. The benchmark covers evaluator construction separately from data-file evaluation so reviewers can see setup cost and per-file filtering cost independently.
InclusiveMetricsEvaluatorandStrictMetricsEvaluator.DataFileobjects.Part of #690.
Test Plan
git diff --check origin/main..HEAD-DICEBERG_BUILD_BENCHMARKS=ONcmake --build build-bench-ci --target metrics_evaluator_benchmarkbuild-bench-ci/src/iceberg/benchmark/metrics_evaluator_benchmark --benchmark_filter=BM_InclusiveMetricsEvaluatorMake/equal_id --benchmark_min_time=0.01scmake --build buildctest --test-dir build --output-on-failuremesonis not installed on this machine.Verification Commands
cmake -S . -B build-bench-ci -G Ninja \ -DICEBERG_BUILD_BENCHMARKS=ON cmake --build build-bench-ci --target metrics_evaluator_benchmark build-bench-ci/src/iceberg/benchmark/metrics_evaluator_benchmark \ --benchmark_filter=BM_InclusiveMetricsEvaluatorMake/equal_id \ --benchmark_min_time=0.01s cmake --build build ctest --test-dir build --output-on-failure