Update hive docker to 4.2.1 - #3924
Conversation
| args: | ||
| MAVEN_MIRROR: ${MAVEN_MIRROR:-https://repo1.maven.org/maven2} |
There was a problem hiding this comment.
Would be nice to keep this. Some folks might be behind a private mirror for vulnerability scanning.
There was a problem hiding this comment.
That's a fantastic point. Adding that back in.
| catalog._client = MagicMock() | ||
| catalog._client.__enter__().create_table.return_value = None | ||
| catalog._client.__enter__().get_table.return_value = hive_table | ||
| catalog._client.__enter__().get_table_req.return_value = GetTableResult(table=hive_table) |
There was a problem hiding this comment.
More of a meta thing, but I think most of these mock tests predate the Hive integration tests, not sure how valuable these are.
There was a problem hiding this comment.
I mostly agree. If it's alright with you, let's get this merged (to unblock the rest of our wonderful contributors) and then I'll send out a quick follow-up to remove the mocks. We can have a discussion there.
(I really dislike mocked tests, so I need very little excuse to get rid of them)
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Thanks @rambleraptor for the quick follow up. I think we should get this in to unblock the failing CI.
damansingh1313
left a comment
damansingh1313
left a comment
There was a problem hiding this comment.
Thanks @rambleraptor for taking up the change! It unblocks everyone's PR.
3 participants
Closes #3922
Rationale for this change
Right now, integration tests are failing because Debian Bullseye has officially reached EOL. We should move our Hive images to the newest version (4.2.1).
Hive 4.0.1 removed
get_tableso there is some changes to the underlying Hive code to make this work properly. There's also some changes to the Dockerfiles outside of just bumping the version.This is a larger lift than just removing the Debian EOL check, but we should do this at some point.
Are these changes tested?
Integration tests should pass.
Are there any user-facing changes?