Fix unit tests that haven't been running - #3937
Merged
kevinjqliu merged 2 commits intoSep 11, 2026
Merged
Conversation
rambleraptor
requested review from
Fokko,
geruh and
kevinjqliu
and removed request for
geruh and
kevinjqliu
September 11, 2026 18:24
Rename the synthesized marker to match its semantics and keep the local unit target from collecting the integration test directory. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kevinjqliu
approved these changes
Sep 11, 2026
kevinjqliu
left a comment
kevinjqliu
left a comment
Contributor
There was a problem hiding this comment.
LGTM! I made a change to rename it from unmarked to unit which better reflects how we use the tests
cb037dc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We have 12 unit tests that haven't been run in CI in months.
We mark unit tests as those that don't have a pytest marker. This means that we falsely mark tests with
filterwarningsor other mundane pytest markers as non-unit tests...and then never run them.The correct thing to do is figure out a list of markers that are integration tests and then have all other tests marked as unit tests.
This also includes fixes for those tests, since they've been broken for a while.
Are these changes tested?
Tests only.
Are there any user-facing changes?