Core: Validate implementation classes loaded from properties - #3951
Open
akashchamp wants to merge 1 commit into
Open
Core: Validate implementation classes loaded from properties#3951akashchamp wants to merge 1 commit into
akashchamp wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3932
Rationale for this change
Table properties can name implementation classes that are imported and instantiated. Those values can come from table metadata, so loading an arbitrary importable class can pass table properties to an unrelated constructor. Each loader now verifies the expected base class before instantiation.
Are these changes tested?
make lintpassed.FileIO,LocationProvider, andS3RetryStrategyimplementations, then confirmed that a wrong-but-importable class was rejected in each path.make testcompleted with 4,105 passed, 5 skipped, and 126 deselected. Three unrelated Hive Kerberos tests failed because this host lackskrb5-configand the native Kerberos module.Are there any user-facing changes?
Yes. Invalid
py-io-impl,write.py-location-provider.impl, ands3.retry-strategy-implvalues now raise a clearValueErrorbefore an unrelated importable class is instantiated. Valid custom implementations continue to load normally.