Skip to content

test(simulator): cover durability failures no existing test can reach - #4132

Merged
spetz merged 5 commits into
masterfrom
review_4092
Sep 11, 2026
Merged

spetz merged 5 commits into
masterfrom
review_4092

Conversation

@numinnex

Copy link
Copy Markdown
Contributor

Adds extra tests scenarios after #4092 PR.

@github-actions github-actions Bot added the S-waiting-on-review PR is waiting on a reviewer label Sep 11, 2026
@codecov

codecov Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 23.17073% with 126 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.13%. Comparing base (73a0bed) to head (5095078).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
core/simulator/src/lib.rs 0.00% 32 Missing ⚠️
core/configs/src/configs_impl/file_provider.rs 0.00% 30 Missing ⚠️
core/partitions/src/iggy_partition.rs 6.66% 28 Missing ⚠️
core/partitions/src/persistence.rs 0.00% 23 Missing ⚠️
core/simulator/src/storage.rs 73.46% 13 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             master    #4132       +/-   ##
=============================================
- Coverage     86.43%   75.13%   -11.31%     
+ Complexity     1455     1454        -1     
=============================================
  Files          1259     1258        -1     
  Lines        205674   187656    -18018     
  Branches     170875   152856    -18019     
=============================================
- Hits         177775   140992    -36783     
- Misses        23466    42283    +18817     
+ Partials       4433     4381       -52     
Components Coverage Δ
Rust Core 73.41% <58.46%> (-13.98%) ⬇️
Java SDK 67.57% <ø> (-0.02%) ⬇️
C# SDK 76.97% <ø> (ø)
Python SDK 91.34% <ø> (ø)
PHP SDK 85.65% <ø> (ø)
Node SDK 96.26% <ø> (+0.08%) ⬆️
Go SDK 69.43% <ø> (+0.03%) ⬆️
Files with missing lines Coverage Δ
core/simulator/src/storage.rs 83.52% <73.46%> (-1.69%) ⬇️
core/partitions/src/persistence.rs 91.34% <0.00%> (-2.33%) ⬇️
core/partitions/src/iggy_partition.rs 92.16% <6.66%> (-0.18%) ⬇️
core/configs/src/configs_impl/file_provider.rs 75.09% <0.00%> (-9.43%) ⬇️
core/simulator/src/lib.rs 95.64% <0.00%> (-0.72%) ⬇️

... and 272 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread core/simulator/src/storage.rs
Comment thread core/simulator/src/storage/tests.rs
Comment thread core/simulator/src/storage/tests.rs Outdated
Comment thread core/integration/tests/cluster/crash_durability.rs
@github-actions github-actions Bot added S-waiting-on-author PR is waiting on author response and removed S-waiting-on-review PR is waiting on a reviewer labels Sep 11, 2026
@spetz
spetz merged commit 91c3ca5 into master Sep 11, 2026
97 checks passed
@spetz
spetz deleted the review_4092 branch September 11, 2026 16:06
@github-actions github-actions Bot removed the S-waiting-on-author PR is waiting on author response label Sep 11, 2026
@numinnex

Copy link
Copy Markdown
Contributor Author

/dst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants