Conversation
A debug server panicked at startup when IGGY_ENV_PATH was set. The boot check and the typed env provider kept separate lists of accepted IGGY_ names, and names that only the boot check accepted hit the provider's debug_assert. The boot check also refused unknown names in release builds. The boot check is now the server's only check. It refuses to boot in debug builds, so CI catches stray names, and only warns in release builds. IGGY_KAFKA_ moves from the provider's list into the boot check's allowed prefixes.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4200 +/- ##
=============================================
- Coverage 87.48% 73.81% -13.68%
Complexity 1575 1575
=============================================
Files 1280 1278 -2
Lines 223192 203555 -19637
Branches 186555 166919 -19636
=============================================
- Hits 195267 150256 -45011
- Misses 23229 48645 +25416
+ Partials 4696 4654 -42
🚀 New features to boost your workflow:
|
A debug build refuses to boot on an IGGY_ name that no mapping claims. One shared environment, or the one .env every binary loads, carries the paths the other two binaries read before their own config load, so a debug iggy-mcp or iggy-connectors refused to boot on its own IGGY_MCP_ENV_PATH or IGGY_CONNECTORS_ENV_PATH. The config path pair was already on the list. The env path pair joins it, under a test. The same review found three smaller things: the runtime-prefix deserialize ran the scan whatever without_unknown_env_var_check said, the process env var test asserted on a Result that cannot be Err, and the set_var safety notes named key uniqueness instead of the serial bound that actually holds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A debug server panicked at startup when
IGGY_ENV_PATHwas set.The boot check and the typed env provider kept separate lists
of accepted
IGGY_names, and names that only the boot checkaccepted hit the provider's debug_assert. The boot check also
refused unknown names in release builds.
The boot check is now the server's only check. It refuses to
boot in debug builds, so CI catches stray names, and only warns
in release builds.
IGGY_KAFKA_moves from the provider's listinto the boot check's allowed prefixes.