Conversation
A single transient curl error failed a whole CI job. One-shot downloads now use --retry 5 --retry-all-errors, with -f so an HTTP 5xx retries instead of being saved as the script or binary. Downloads piped into tar or gunzip stage to a temp file first, because curl cannot rewind a pipe on retry. Polling loops keep their own backoff and are unchanged. Dry runs and skip_tag_creation runs listed tags as "Will create" although neither pushes a tag. They now say "Would create". The source release tarball now carries rust-toolchain.toml, so a build from it uses the pinned toolchain. Also quote the SC2086 sites that do not rely on word splitting.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4216 +/- ##
============================================
- Coverage 87.48% 87.48% -0.01%
- Complexity 1575 1577 +2
============================================
Files 1280 1280
Lines 223192 223192
Branches 186555 186555
============================================
- Hits 195267 195255 -12
+ Misses 23229 23207 -22
- Partials 4696 4730 +34
🚀 New features to boost your workflow:
|
Contributor
Author
|
don't merge this until 0.9.0 is released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single transient curl error failed a whole CI job. One-shot
downloads now use --retry 5 --retry-all-errors, with -f so an
HTTP 5xx retries instead of being saved as the script or binary.
Downloads piped into tar or gunzip stage to a temp file first,
because curl cannot rewind a pipe on retry. Polling loops keep
their own backoff and are unchanged.
Dry runs and skip_tag_creation runs listed tags as "Will create"
although neither pushes a tag. They now say "Would create".
The source release tarball now carries rust-toolchain.toml, so a
build from it uses the pinned toolchain.
Also quote the SC2086 sites that do not rely on word splitting.