JSPWIKI-1294 see jira for details - #521
Open
spyhunter99 wants to merge 1 commit into
Open
spyhunter99 wants to merge 1 commit into
spyhunter99 wants to merge 1 commit into
Conversation
| * @return The absolute URL as a String. | ||
| * @since 2.12.2 | ||
| */ | ||
| public static String getAbsoluteUrl(final HttpServletRequest request, final String relativeUrl) { |
Contributor
There was a problem hiding this comment.
not sure about the best way of handling this, as this would break the RSS if JSPWiki is served behind some kind of proxy / web server. IIRC, initially we had a jspwiki property for the url, then, as it was only used on the rss feed we tried to resolve from path (as this PR does now). Unfortunately, this broke the RSS and we ended up with today's code. Perhaps we should bring back the baseUrl property? I'll chime in at JSPWIKI-1294 with some more remarks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.