feat(gemini): integrate gemini cli as runtime - #1199
Draft
sjyangkevin wants to merge 1 commit into
Draft
Conversation
Gemini already discovers Magpie skills, but its shell calls do not reach the action guard and its spec-loop profile ignores the requested output format. Add a BeforeTool adapter for the existing dispatch core and register it in project settings using a portable path. Import AGENTS.md from GEMINI.md and forward the output format in the Gemini runner profile. Document the implemented runtime contract and manual hook registration for snapshot adopters. Cover the hook protocol, project configuration, and runner arguments with tests. Policy distribution and sandbox parity remain follow-up work for issue apache#314. Refs: apache#314 Generated-by: Codex (GPT-6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BeforeTooladapter and project.gemini/settings.json. The hook uses a portable path and preserves the shared guard decisions.AGENTS.mdfromGEMINI.mdand forward the requested output format through the existing Gemini spec-loop profile, reusing the canonical skill sources.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-filespassesuv run pytest/ruff check/mypypasses(
PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
RFC-AI-0004 compliance
<PROJECT>,<tracker>,<upstream>,<security-list>) used in all skill / tool prose (thecheck-placeholdersprek hook is the mechanical gate)Linked issues
Refs #314.
Notes for reviewers (optional)
Metadata validation reports 38 existing advisory warnings. The workspace test run used temporary
jqdependencies and a clean temporary directory to avoid an existing/tmp/.gitin the local environment.Generative AI disclosure: Codex (GPT-6) assisted with implementation, documentation, tests, and preparation of this PR description.