test(desktop): isolate side-chat slash dispatch - #3291
Merged
Conversation
The slash-command E2E chained an unrelated steering submission before exercising /side, creating a race against the composer's async draft settlement. Steering already has dedicated Desktop E2E coverage, so keep this scenario focused on the running-turn slash dispatch contract.
M4n5ter
marked this pull request as ready for review
August 20, 2026 06:22
Astro-Han
approved these changes
Aug 20, 2026
Astro-Han
left a comment
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
LGTM. It fixed the Flaky test with minimal change.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/sideslash-command E2EFixes #2916.
Root cause
The test chained two asynchronous submissions. Under CI load, the second slash-menu interaction could begin while the steering submission still owned the previous draft, producing
/compact explain/instead of/and leaving no/sideoption to select. The same failure appeared on unrelated PRs #3242 and #3278.The steering behavior is already covered by
streaming-remount.spec.ts, so removing that duplicate prelude eliminates the race without adding another timing fence or product state solely for a test.Verification
/sideE2E repeated 10 times: 10/10 passed/sidedispatch and the independent live-turn steering E2E: 2/2 passedgit diff --checkpassed