fix(ui): show one spinner throughout live turns - #3350
Open
Colafornia wants to merge 1 commit into
Open
Conversation
Hand spinner ownership between running tools and the turn status so live output always has one activity indicator. Generated-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
During a live turn, a completed tool row could appear above the working status while no animated indicator showed that output was still in progress.
The expected behavior is one active spinner—not zero or two—throughout a live turn.
When the turn reaches a terminal state, the running status disappears and no spinner remains.
The previous implementation removed the spinner from
TurnRunningStatusto prevent duplicate animation during tool calls. This also removed the only animated indicator between tool calls.This change detects in-flight tools with the shared
isInFlightToolStatushelper. The turn status renders the existing AstryxSpinneronly when no tool owns the active spinner.The working copy, elapsed timer, timeline folding, and tool-row behavior remain unchanged. The spinner is decorative for assistive technology, while the status row keeps its accessible name.
Verification
npm --workspace @maka/ui test— 184 tests passedgit diff --cached --check— passedAI use
Select exactly one:
Tool(s) and scope: Codex diagnosed the missing activity state, implemented conditional spinner ownership, added regression coverage, and drafted this pull request.
Checklist
Does this PR entail a change in behavior?