Repository navigation
[OPENJPA-3058] Map BigInteger to NUMERIC on H2 - #258
Merged
Merged
Conversation
…rload used by column mapping
cristof
approved these changes
Nov 2, 2026
solomax
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/OPENJPA-3058
On H2 a
BigIntegerattribute got aBIGINTcolumn, so values with more than 19 digits failed with "Numeric value out of range".H2DictionarymappedBigIntegertoNUMERIConly ingetJDBCType(int, boolean), but column mapping calls the overload with precision and scale, so the DDL never used it.getJDBCType(int, boolean, int, int), which all overloads go through, so DDL and casts agree.StoreLargeNumbersAsStringsand other dictionaries are unchanged.NUMERIC, existingBIGINTcolumns keep working.New
TestH2BigIntegerTypeandTestBigIntegerMapping(30-digit value as field, primary key, foreign key and query parameter). Merges cleanly with #256. Full suites pass on Derby and H2.