Skip to content

chore: sort exports for reqsign-core #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tisonkun wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: sort exports for reqsign-core #872

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10db517
chore: sort exports for reqsign-core
tisonkun Sep 9, 2026
af8e4f6
Merge branch 'main' into exports
Xuanwo Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 40 additions & 34 deletions core/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,48 +180,54 @@
// Make sure all our public APIs have docs.
#![warn(missing_docs)]

/// Error types for reqsign operations
pub mod error;
mod futures_util;
pub mod hash;
#[cfg(all(not(target_arch = "wasm32"), feature = "jwt"))]
pub mod jwt;
pub mod time;
pub mod utils;

pub use error::{Error, ErrorKind, Result};
pub use futures_util::BoxedFuture;
pub use futures_util::MaybeSend;
mod api;
pub use self::api::GrantCredential;
pub use self::api::GrantCredentialDyn;
pub use self::api::ProvideCredential;
pub use self::api::ProvideCredentialChain;
pub use self::api::ProvideCredentialDyn;
pub use self::api::SignRequest;
pub use self::api::SignRequestDyn;
pub use self::api::SigningCredential;

mod context;
pub use context::CommandExecute;
pub use context::CommandExecuteDyn;
pub use context::CommandOutput;
pub use context::Context;
pub use context::Env;
pub use context::FileRead;
pub use context::FileReadDyn;
pub use context::HttpSend;
pub use context::HttpSendDyn;
pub use context::NoopCommandExecute;
pub use context::NoopEnv;
pub use context::NoopFileRead;
pub use context::NoopHttpSend;
pub use context::OsEnv;
pub use context::StaticEnv;
pub use self::context::CommandExecute;
pub use self::context::CommandExecuteDyn;
pub use self::context::CommandOutput;
pub use self::context::Context;
pub use self::context::Env;
pub use self::context::FileRead;
pub use self::context::FileReadDyn;
pub use self::context::HttpSend;
pub use self::context::HttpSendDyn;
pub use self::context::NoopCommandExecute;
pub use self::context::NoopEnv;
pub use self::context::NoopFileRead;
pub use self::context::NoopHttpSend;
pub use self::context::OsEnv;
pub use self::context::StaticEnv;

mod error;

@tisonkun tisonkun Sep 9, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes pub mod error to mod error but we export all symbols of error already.

So I'm considering this as a "bugfix" instead of a breaking change.

pub use self::error::Error;
pub use self::error::ErrorKind;
pub use self::error::Result;

mod futures_util;
pub use self::futures_util::BoxedFuture;
pub use self::futures_util::MaybeSend;

mod granter;
pub use self::granter::Granter;

mod api;
pub use api::GrantCredential;
pub use api::GrantCredentialDyn;
pub use api::ProvideCredential;
pub use api::ProvideCredentialChain;
pub use api::ProvideCredentialDyn;
pub use api::SignRequest;
pub use api::SignRequestDyn;
pub use api::SigningCredential;
mod request;
pub use request::{SigningMethod, SigningRequest};
pub use self::request::SigningMethod;
pub use self::request::SigningRequest;

mod signer;
pub use signer::Signer;
mod granter;
pub use granter::Granter;
pub use self::signer::Signer;
Loading