Skip to content

Scope credential headers in http.custom.headers to hosts #2162

Description

@rzo1

Follow-up to #2089.

The PR for #2089 limits http.basicauth.* credentials to the hosts listed in http.basicauth.hosts. Credential headers configured through http.custom.headers (Authorization, Cookie, X-Api-Key, anything in http.credentials.headers) are still sent to every host; only a startup WARN was added.

Scoping them needs its own design, e.g. a per-host form of http.custom.headers, and is a separate breaking change. Today the only per-site alternative is protocol.set-header metadata, which is awkward for seed-based crawls.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions