Conversation
…in the new http.basicauth.hosts key and warn about credential headers in http.custom.headers.
dpol1
approved these changes
Sep 16, 2026
| || !parsed.equals( | ||
| new HttpUrl.Builder().scheme("http").host(parsed.host()).build())) { | ||
| LOG.warn( | ||
| "Ignoring '{}' in http.basicauth.hosts, expected a host name or IP address " |
Member
There was a problem hiding this comment.
could we not log the value here? a pasted URL with user:pw in it would end up in the logs, like the proxy string in #2151
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2089. Scoping credential headers in
http.custom.headersis tracked in #2162.Adds
http.basicauth.hosts. The basic auth header is sent only to listed hosts (page fetches and robots.txt); credential headers inhttp.custom.headersnow log a WARN.Release note (breaking):
http.basicauth.userwithouthttp.basicauth.hostsno longer sends credentials; a WARN is logged at startup.