test(pyright-language-service): add smoke test and CI wiring for pyright bridge - #7293
Open
rbelavadi wants to merge 1 commit into
Open
test(pyright-language-service): add smoke test and CI wiring for pyright bridge#7293rbelavadi wants to merge 1 commit into
rbelavadi wants to merge 1 commit into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
Author
|
/request-review @Yicong-Huang |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7293 +/- ##
============================================
+ Coverage 77.30% 83.03% +5.72%
- Complexity 3524 4107 +583
============================================
Files 1161 1165 +4
Lines 45922 46405 +483
Branches 5101 5171 +70
============================================
+ Hits 35501 38532 +3031
+ Misses 8840 6170 -2670
- Partials 1581 1703 +122
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
✅ No material benchmark regressions detected🟢 7 better · 🔴 0 worse · ⚪ 8 noise (<±5%) · 0 without baseline
Baseline detailsLatest main
Raw CSVconfig_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,456.94,200,128000,438,0.267,21703.12,32594.39,32594.39
1,100,10,64,20,2076.32,2000,1280000,963,0.588,104122.09,125319.77,125319.77
2,1000,10,64,20,18040.19,20000,12800000,1109,0.677,898351.39,987520.10,987520.10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
pyright-language-servicehas no test coverage today, a dependency bump can pass CI while silently breaking the WebSocket-to-pyright bridge at runtime (e.g. #6176's express upgrade), and the only way to catch that is starting the service by hand.Adds
src/main.smoke.spec.ts: boots the real service as a subprocess and drives it over WebSocket, covering the happy path (diagnostics for a bad file), clean/empty/unicode documents, and negative cases (unknown method, malformed frame, unknown WS path). No source changes, the unknown-path hang is a pre-existing gap inupgradeWsServer, characterized here rather than fixed; follow-up issue to come.Also fixes a stale comment on the CI job claiming this service has no coverage.
Any related issues, documentation, discussions?
Closes #6193
How was this PR tested?
yarn --cwd pyright-language-service test, 8/8 passing. Wired into.github/workflows/build.ymlafter the existing typecheck step, so it runs on future PRs automatically.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.8)