Skip to content

test(pyright-language-service): add smoke test and CI wiring for pyright bridge - #7293

Open
rbelavadi wants to merge 1 commit into
apache:mainfrom
rbelavadi:test/6193-pyright-language-service-smoke-test
Open

test(pyright-language-service): add smoke test and CI wiring for pyright bridge#7293
rbelavadi wants to merge 1 commit into
apache:mainfrom
rbelavadi:test/6193-pyright-language-service-smoke-test

Conversation

@rbelavadi

@rbelavadi rbelavadi commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

pyright-language-service has no test coverage today, a dependency bump can pass CI while silently breaking the WebSocket-to-pyright bridge at runtime (e.g. #6176's express upgrade), and the only way to catch that is starting the service by hand.

Adds src/main.smoke.spec.ts: boots the real service as a subprocess and drives it over WebSocket, covering the happy path (diagnostics for a bad file), clean/empty/unicode documents, and negative cases (unknown method, malformed frame, unknown WS path). No source changes, the unknown-path hang is a pre-existing gap in upgradeWsServer, characterized here rather than fixed; follow-up issue to come.

Also fixes a stale comment on the CI job claiming this service has no coverage.

Any related issues, documentation, discussions?

Closes #6193

How was this PR tested?

yarn --cwd pyright-language-service test, 8/8 passing. Wired into .github/workflows/build.yml after the existing typecheck step, so it runs on future PRs automatically.

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 4.8)

@github-actions github-actions Bot added dependencies Pull requests that update a dependency file ci changes related to CI pyright-language-service Changes under pyright-language-service/ (Pyright LSP bridge) labels Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • Contributors with relevant context: @aglinxinyuan, @renovate-bot
    You can notify them by mentioning @aglinxinyuan, @renovate-bot in a comment.

@rbelavadi

Copy link
Copy Markdown
Contributor Author

/request-review @Yicong-Huang

@github-actions
github-actions Bot requested a review from Yicong-Huang August 3, 2026 20:57
@codecov-commenter

codecov-commenter commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.03%. Comparing base (a351f44) to head (ff2af0b).
⚠️ Report is 165 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7293      +/-   ##
============================================
+ Coverage     77.30%   83.03%   +5.72%     
- Complexity     3524     4107     +583     
============================================
  Files          1161     1165       +4     
  Lines         45922    46405     +483     
  Branches       5101     5171      +70     
============================================
+ Hits          35501    38532    +3031     
+ Misses         8840     6170    -2670     
- Partials       1581     1703     +122     
Flag Coverage Δ
access-control-service 70.00% <ø> (ø)
agent-service 83.65% <ø> (+6.89%) ⬆️
amber 79.99% <ø> (+10.89%) ⬆️
computing-unit-managing-service 43.60% <ø> (+23.11%) ⬆️
config-service 65.97% <ø> (-0.69%) ⬇️
file-service 67.74% <ø> (+0.52%) ⬆️
frontend 83.84% <ø> (+1.26%) ⬆️
notebook-migration-service 78.89% <ø> (-0.06%) ⬇️
pyamber 97.36% <ø> (+5.21%) ⬆️
workflow-compiling-service 26.31% <ø> (-28.84%) ⬇️

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

✅ No material benchmark regressions detected

🟢 7 better · 🔴 0 worse · ⚪ 8 noise (<±5%) · 0 without baseline

Compared against main 7f6402d benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.

Dashboard · Run

config throughput MB/s latency max Δ latest / 7d
🟢 bs=10 sw=10 sl=64 438 0.267 21,703/32,594/32,594 us 🟢 -31.2% / 🔴 +112.5%
🟢 bs=100 sw=10 sl=64 963 0.588 104,122/125,320/125,320 us 🟢 -22.0% / 🔴 +19.1%
bs=1000 sw=10 sl=64 1,109 0.677 898,351/987,520/987,520 us ⚪ within ±5% / 🟢 -6.8%
Baseline details

Latest main 7f6402d from same runner

config metric PR latest main 7d avg Δ latest Δ 7d
bs=10 sw=10 sl=64 throughput 438 tuples/sec 410 tuples/sec 791.9 tuples/sec +6.8% -44.7%
bs=10 sw=10 sl=64 MB/s 0.267 MB/s 0.25 MB/s 0.483 MB/s +6.8% -44.8%
bs=10 sw=10 sl=64 p50 21,703 us 23,379 us 12,391 us -7.2% +75.2%
bs=10 sw=10 sl=64 p95 32,594 us 47,376 us 15,336 us -31.2% +112.5%
bs=10 sw=10 sl=64 p99 32,594 us 47,376 us 18,924 us -31.2% +72.2%
bs=100 sw=10 sl=64 throughput 963 tuples/sec 965 tuples/sec 1,018 tuples/sec -0.2% -5.4%
bs=100 sw=10 sl=64 MB/s 0.588 MB/s 0.589 MB/s 0.622 MB/s -0.2% -5.4%
bs=100 sw=10 sl=64 p50 104,122 us 99,628 us 98,925 us +4.5% +5.3%
bs=100 sw=10 sl=64 p95 125,320 us 160,574 us 105,265 us -22.0% +19.1%
bs=100 sw=10 sl=64 p99 125,320 us 160,574 us 112,729 us -22.0% +11.2%
bs=1000 sw=10 sl=64 throughput 1,109 tuples/sec 1,123 tuples/sec 1,051 tuples/sec -1.2% +5.5%
bs=1000 sw=10 sl=64 MB/s 0.677 MB/s 0.686 MB/s 0.641 MB/s -1.3% +5.5%
bs=1000 sw=10 sl=64 p50 898,351 us 891,933 us 964,104 us +0.7% -6.8%
bs=1000 sw=10 sl=64 p95 987,520 us 945,409 us 1,002,343 us +4.5% -1.5%
bs=1000 sw=10 sl=64 p99 987,520 us 945,409 us 1,030,483 us +4.5% -4.2%
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,456.94,200,128000,438,0.267,21703.12,32594.39,32594.39
1,100,10,64,20,2076.32,2000,1280000,963,0.588,104122.09,125319.77,125319.77
2,1000,10,64,20,18040.19,20000,12800000,1109,0.677,898351.39,987520.10,987520.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci changes related to CI dependencies Pull requests that update a dependency file pyright-language-service Changes under pyright-language-service/ (Pyright LSP bridge)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add automated tests for pyright-language-service

2 participants