Skip to content

[To dev/1.1] Fix NPE when closing an unused last reader - #1124

Merged
jt2594838 merged 1 commit into
apache:dev/1.1from
Caideyipi:cp/fix-last-reader-close-dev-1.1-20261118
Nov 18, 2026
Merged

jt2594838 merged 1 commit into
apache:dev/1.1from
Caideyipi:cp/fix-last-reader-close-dev-1.1-20261118

Conversation

@Caideyipi

Copy link
Copy Markdown
Contributor

Backport the fix from #513 to the 1.1 line. TsFileLastReader.close() now cancels the asynchronous task only after initialization, then always closes the underlying sequence reader. Add a regression test that closes a newly created reader without reading. Verified with: mvn test -P with-java -pl java/tsfile -am -Dtest=TsFileLastReaderTest#testCreateButNotRead -Dsurefire.failIfNoSpecifiedTests=false.

* fix npe when closing a last reader that have not been used

* spotless
@jt2594838
jt2594838 merged commit a08214f into apache:dev/1.1 Nov 18, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants