Skip to content

Fix Windows CI failures for the Python wheel build. - #831

Merged
jt2594838 merged 9 commits into
apache:rc/2.3.1from
hongzhi-gao:rc/2.3.1
Jun 9, 2026
Merged

jt2594838 merged 9 commits into
apache:rc/2.3.1from
hongzhi-gao:rc/2.3.1

Conversation

@hongzhi-gao

@hongzhi-gao hongzhi-gao commented Jun 8, 2026 •

Copy link
Copy Markdown
Contributor

Changes:

  • Fix MinGW C++ build failure by removing problematic FORCE_INLINE usage from AndFilter and OrFilter.
  • Package and preload required MinGW runtime DLLs with Windows wheels to avoid WinError 127 on import.
  • Ensure Windows wheel jobs use the expected Python/MSYS2 paths and verify C++ artifacts before building wheels.
  • Skip Python tests during wheel packaging while keeping wheel import verification.
  • Sync Python package version to 2.3.1.
  • Fix C++ Spotless formatting violations.

Validation:

  • mvnw.cmd -P with-cpp spotless:check
  • pytest tests on Windows, 144 passed.

GCC on Windows CI fails when always_inline virtual methods exceed the max-inline-insns-single limit during expression.cc compilation.
Restore MinGW runtime preloading in __init__.py removed during MSVC support. Improve setup.py to locate MinGW DLLs via MSYSTEM_PREFIX and harden wheels.yml Windows build/verify steps.
Link gcc_s/stdc++ before libtsfile on MinGW so _Unwind_Resume is not imported from libtsfile.dll (WinError 127). Honor -DskipTests in exec-maven-plugin for pytest, and add -Dmaven.test.skip=true in wheels CI.
@hongzhi-gao hongzhi-gao changed the title Rc/2.3.1 Fix Windows CI failures for the Python wheel build. Jun 9, 2026
@jt2594838
jt2594838 merged commit b1ec548 into apache:rc/2.3.1 Jun 9, 2026
38 checks passed
@jt2594838
jt2594838 deleted the rc/2.3.1 branch June 9, 2026 07:13
jt2594838 pushed a commit that referenced this pull request Jun 10, 2026
* Fix Windows CI failures for the Python wheel build. (#831)

* fix(cpp): remove FORCE_INLINE from AndFilter/OrFilter for MinGW build

GCC on Windows CI fails when always_inline virtual methods exceed the max-inline-insns-single limit during expression.cc compilation.

* fix(python): preload MinGW runtime DLLs on Windows wheel import

Restore MinGW runtime preloading in __init__.py removed during MSVC support. Improve setup.py to locate MinGW DLLs via MSYSTEM_PREFIX and harden wheels.yml Windows build/verify steps.

* fix(python): fix MinGW .pyd linking and skip tests during wheel build

Link gcc_s/stdc++ before libtsfile on MinGW so _Unwind_Resume is not imported from libtsfile.dll (WinError 127). Honor -DskipTests in exec-maven-plugin for pytest, and add -Dmaven.test.skip=true in wheels CI.

* Fix Windows wheel MinGW runtime packaging

* Remove unrelated setup.py version bump

* Fix cpp formatting and sync Python version

* Fix MinGW filter inlining for rc build

* Avoid forced inline for nested time filters

* Avoid forced inline for nested statistic filters

* Sync C++/Python version to 2.3.2.dev with Maven 2.3.2-SNAPSHOT

* Fix C example string duplication for Linux wheels
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants