Repository navigation
Fix Windows CI failures for the Python wheel build. - #831
Merged
Merged
Conversation
GCC on Windows CI fails when always_inline virtual methods exceed the max-inline-insns-single limit during expression.cc compilation.
Restore MinGW runtime preloading in __init__.py removed during MSVC support. Improve setup.py to locate MinGW DLLs via MSYSTEM_PREFIX and harden wheels.yml Windows build/verify steps.
Link gcc_s/stdc++ before libtsfile on MinGW so _Unwind_Resume is not imported from libtsfile.dll (WinError 127). Honor -DskipTests in exec-maven-plugin for pytest, and add -Dmaven.test.skip=true in wheels CI.
jt2594838
approved these changes
Jun 9, 2026
jt2594838
pushed a commit
that referenced
this pull request
Jun 10, 2026
* Fix Windows CI failures for the Python wheel build. (#831) * fix(cpp): remove FORCE_INLINE from AndFilter/OrFilter for MinGW build GCC on Windows CI fails when always_inline virtual methods exceed the max-inline-insns-single limit during expression.cc compilation. * fix(python): preload MinGW runtime DLLs on Windows wheel import Restore MinGW runtime preloading in __init__.py removed during MSVC support. Improve setup.py to locate MinGW DLLs via MSYSTEM_PREFIX and harden wheels.yml Windows build/verify steps. * fix(python): fix MinGW .pyd linking and skip tests during wheel build Link gcc_s/stdc++ before libtsfile on MinGW so _Unwind_Resume is not imported from libtsfile.dll (WinError 127). Honor -DskipTests in exec-maven-plugin for pytest, and add -Dmaven.test.skip=true in wheels CI. * Fix Windows wheel MinGW runtime packaging * Remove unrelated setup.py version bump * Fix cpp formatting and sync Python version * Fix MinGW filter inlining for rc build * Avoid forced inline for nested time filters * Avoid forced inline for nested statistic filters * Sync C++/Python version to 2.3.2.dev with Maven 2.3.2-SNAPSHOT * Fix C example string duplication for Linux wheels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Validation: