Repository navigation
fix invalid datatype. - #864
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #864 +/- ##
========================================
Coverage 60.52% 60.53%
========================================
Files 735 735
Lines 48439 48447 +8
Branches 7679 7679
========================================
+ Hits 29319 29328 +9
Misses 17718 17718
+ Partials 1402 1401 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
hongzhi-gao
approved these changes
Jul 13, 2026
jt2594838
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tree by-row query with
limit=0(oroffsetpast the end) fails on asingle-path query — Python raises
ValueError: 254 is not a valid TSDataType(254 = C++
NULL_TYPE).Cause
In
QDSWithoutTimeGenerator::init_internal, column types were taken from thefirst decoded
TsBlock, falling back toNULL_TYPEwhen none exists. For asingle path,
limit == 0makes the scan iterator return no block, so the typebecame
NULL_TYPE (254), which the Python enum rejects.Fix
Capture the column type from the timeseries index (via the SSI) in the alloc
loop — before any
TsBlockis read — and use it as the fallback instead ofNULL_TYPE. This matches how Java derives types (from metadata, not from data).Tests
LimitZero/OffsetExceedsTotalRows: assert the metadata type is thereal type (
INT64), notNULL_TYPE.test_query_tree_by_row_limit_zero: single-path (INT64/DOUBLE/BOOLEAN/STRING), multi-path, and offset-past-end.