Repository navigation
Try atomic bodies - #31
Open
andrewcmyers wants to merge 13 commits into
Open
andrewcmyers wants to merge 13 commits into
andrewcmyers wants to merge 13 commits into
Conversation
…ing contracts in labels.
…he leaky semantics, and pick up SHErrLoc's hypothesis-soundness fixes.
exception types are now checked properly and support dependent types.
…ositional for both reads and writes, and receivers can be any variable, member or element.
… by adding a Block node to the AST to replace the previous fairly ad-hoc 'list of statements' approach. Also got rid of the endorse statement that was not really suppored anyway.
…nodes; throw and emit take a name and arguments and share argument checking with calls, which makes emit sound when a principal argument is not a name.
…ad by struct construction, contract creation, call receivers and call specs.
failures. Reject return statements that do not match the method's return type and call options on calls that are not external method calls. Clearer errors for new.
Open
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To merge after #29.
This fixes a bug in try and atomic. The methods generated for try and atomic bodies now receive the locals read by struct construction, contract creation, call receivers and call specs, which they previously did not, breaking the generated Solidity code.
I also rolled in a few other small bug fixes.