fix(release): store quick start assembly with Git LFS - #125
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The LFS pointer, workflow checkout configuration, and user documentation consistently address the repository file-size limitation.
Review effort: Balanced
Findings: None
What changed in this PR
Stores the quick-start assembly JAR with Git LFS to avoid GitHub’s file-size limit during release synchronization.
Changes:
- Tracks the all-in-one JAR through Git LFS.
- Enables LFS checkout in release and Docker workflows.
- Documents LFS setup for new and existing clones.
| File | Description |
|---|---|
.gitattributes |
Configures LFS tracking for the JAR. |
apollo-all-in-one.jar |
Converts the JAR to an LFS pointer. |
.github/workflows/sync-apollo-release.yml |
Fetches LFS content during release synchronization. |
.github/workflows/docker-publish.yml |
Restores the JAR before building images. |
README.md |
Documents Git LFS requirements. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Apollo 3.0.0 produces a 125.90 MiB all-in-one JAR, so the release sync workflow fails when GitHub rejects the branch push above the 100 MiB Git file limit.
Track
apollo-all-in-one.jarwith Git LFS and enable LFS checkout in both release workflows. The Docker workflow explicitly restores the JAR before building. The existing JAR is converted to an LFS pointer without changing its bytes, and README documents the Git LFS steps for new and existing clones. The file path and start commands remain the same.Validation: original JAR SHA-256 preserved; LFS clean/smudge round trip passed;
git lfs fsck --objects --pointerspassed; both workflow YAML files parsed;git diff --checkpassed. The 3.0.0 sync workflow will be retried after merge.Repository setting: enable “Include Git LFS objects in archives” so Download ZIP continues to include the complete JAR.
Summary by CodeRabbit