Skip to content

fix(release): store quick start assembly with Git LFS - #125

Merged
nobodyiam merged 1 commit into
masterfrom
codex/quick-start-lfs
Oct 3, 2026
Merged

nobodyiam merged 1 commit into
masterfrom
codex/quick-start-lfs

Conversation

@nobodyiam

@nobodyiam nobodyiam commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

Apollo 3.0.0 produces a 125.90 MiB all-in-one JAR, so the release sync workflow fails when GitHub rejects the branch push above the 100 MiB Git file limit.

Track apollo-all-in-one.jar with Git LFS and enable LFS checkout in both release workflows. The Docker workflow explicitly restores the JAR before building. The existing JAR is converted to an LFS pointer without changing its bytes, and README documents the Git LFS steps for new and existing clones. The file path and start commands remain the same.

Validation: original JAR SHA-256 preserved; LFS clean/smudge round trip passed; git lfs fsck --objects --pointers passed; both workflow YAML files parsed; git diff --check passed. The 3.0.0 sync workflow will be retried after merge.

Repository setting: enable “Include Git LFS objects in archives” so Download ZIP continues to include the complete JAR.

Summary by CodeRabbit

  • Documentation
    • Added English and Chinese instructions for setting up Git LFS when downloading the all-in-one JAR, including steps for existing clones.
  • Chores
    • Updated release and Docker publishing workflows to restore the JAR correctly, helping ensure it is available in published builds.

Copilot AI balanced review requested due to automatic review settings October 3, 2026 13:05
@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 95468bad-14a9-4d23-935f-9f405dee6fb6
📥 Commits

Reviewing files that changed from the base of the PR and between aaa77a1 and 74a6a97.

⛔ Files ignored due to path filters (1)
  • apollo-all-in-one.jar is excluded by !**/*.jar
📒 Files selected for processing (4)
  • .gitattributes
  • .github/workflows/docker-publish.yml
  • .github/workflows/sync-apollo-release.yml
  • README.md
 _______________________________________________________
< Coding ain't done 'til all the Tests run. 'Nuff said. >
 -------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-03T13:09:27.860047Z 74a6a97 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@mergify

mergify Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@nobodyiam
nobodyiam merged commit b1d261f into master Oct 3, 2026
3 of 4 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The LFS pointer, workflow checkout configuration, and user documentation consistently address the repository file-size limitation.

Review effort: Balanced
Findings: None

What changed in this PR

Stores the quick-start assembly JAR with Git LFS to avoid GitHub’s file-size limit during release synchronization.

Changes:

  • Tracks the all-in-one JAR through Git LFS.
  • Enables LFS checkout in release and Docker workflows.
  • Documents LFS setup for new and existing clones.
File Description
.gitattributes Configures LFS tracking for the JAR.
apollo-all-in-one.jar Converts the JAR to an LFS pointer.
.github/​workflows/​sync-apollo-release.yml Fetches LFS content during release synchronization.
.github/​workflows/​docker-publish.yml Restores the JAR before building images.
README.md Documents Git LFS requirements.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@nobodyiam
nobodyiam deleted the codex/quick-start-lfs branch October 4, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants