Skip to content

fix: expose Docker application startup logs - #129

Merged
nobodyiam merged 1 commit into
masterfrom
codex/quick-start-console-logs
Oct 4, 2026
Merged

nobodyiam merged 1 commit into
masterfrom
codex/quick-start-console-logs

Conversation

@nobodyiam

@nobodyiam nobodyiam commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

Docker Quick Start now runs Java in the foreground, but the inherited LOG_APPENDERS=FILE default hides application startup and failure messages from docker logs. Users see Spring Boot banners without the old launcher's readiness messages.

Set the Docker image default to LOG_APPENDERS=FILE,CONSOLE. Startup messages such as portalContext [...] isActive: true become visible while file logging remains available. Document the readiness marker and shared log path in the English and Chinese README sections. demo.sh and the Apollo JAR remain unchanged; users can still override the appender setting.

Validation:

  • Local image built successfully.
  • 5 Docker tests passed under umask 077, covering the new default and explicit override as well as PID 1, privilege dropping, graceful shutdown, and background zombie handling.
  • Real Apollo 3.0.0 + MySQL 8.0 smoke test on Linux arm64 verified startup success markers for all three services in docker logs, matching file logs, HTTP endpoints, and graceful stop.
  • git diff --check passed.

Image republication will follow maintainer confirmation. The Docker deployment guide is updated in apolloconfig/apollo#5689.

Copilot AI balanced review requested due to automatic review settings October 4, 2026 05:23
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-04T05:26:26.570694Z 0a14e35 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d6d5c5e1-138f-4b62-a38b-5a7891cbab53
📥 Commits

Reviewing files that changed from the base of the PR and between 6e18f1a and 0a14e35.

📒 Files selected for processing (3)
  • Dockerfile
  • README.md
  • scripts/test_demo_docker.py

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The Docker image now defaults to LOG_APPENDERS=FILE,CONSOLE. The README documents the default log destinations, Portal startup indicator, Portal URL, and how to override the setting. Docker tests check the default and an override.

Changes

Docker logging configuration

Layer / File(s) Summary
Configure and verify log destinations
Dockerfile, scripts/test_demo_docker.py, README.md
The Dockerfile sets LOG_APPENDERS to FILE,CONSOLE. Docker tests check the default and a FILE override. The English and Chinese README sections document log destinations, Portal startup, the Portal URL, and the override.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 0a14e

The image default and explicit override reach the application, and the supplied smoke-test report says startup logs appeared in Docker and the file. No concrete merge-blocking issue is established.

Security Architecture Review

Security architecture risk: 🔵 Low · up to 0a14e

The change is narrowly scoped and preserves an explicit logging override. No privilege expansion or new application endpoint was identified. However, the application’s actual console log contents and deployment-specific log readership could not be verified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — If the application implements the documented console appender behavior, application log data will additionally reach the container’s logging channel. The affected scope is containers using the new default; actual readership, downstream collection, and data sensitivity remain unverified.

Trust Boundaries and Controls

  • observed — Appender selection remains an environment-controlled setting passed to Java rather than a new application request input. The launcher does not parse it into commands. Docker log authorization controls are outside the available evidence.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (2 skipped: 2 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: exposing Docker application startup logs.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (2 skipped: 2 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The implementation, tests, and documentation consistently provide the intended Docker log visibility without changing direct script defaults.

Review effort: Balanced
Findings: None

What changed in this PR

Exposes Apollo startup logs through Docker while retaining file logging and override support.

Changes:

  • Defaults Docker logging to FILE,CONSOLE.
  • Tests the default and explicit override.
  • Documents log destinations and readiness markers in English and Chinese.
File Description
Dockerfile Adds the container logging default.
scripts/​test_demo_docker.py Verifies default and overridden appenders.
README.md Documents Docker logging and readiness.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@nobodyiam
nobodyiam merged commit 08e7a08 into master Oct 4, 2026
4 checks passed
@nobodyiam
nobodyiam deleted the codex/quick-start-console-logs branch October 4, 2026 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants