Repository navigation
fix: expose Docker application startup logs - #129
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughThe Docker image now defaults to ChangesDocker logging configuration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The image default and explicit override reach the application, and the supplied smoke-test report says startup logs appeared in Docker and the file. No concrete merge-blocking issue is established. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change is narrowly scoped and preserves an explicit logging override. No privilege expansion or new application endpoint was identified. However, the application’s actual console log contents and deployment-specific log readership could not be verified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 1 files. (2 skipped: 2 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation, tests, and documentation consistently provide the intended Docker log visibility without changing direct script defaults.
Review effort: Balanced
Findings: None
What changed in this PR
Exposes Apollo startup logs through Docker while retaining file logging and override support.
Changes:
- Defaults Docker logging to
FILE,CONSOLE. - Tests the default and explicit override.
- Documents log destinations and readiness markers in English and Chinese.
| File | Description |
|---|---|
Dockerfile |
Adds the container logging default. |
scripts/test_demo_docker.py |
Verifies default and overridden appenders. |
README.md |
Documents Docker logging and readiness. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Docker Quick Start now runs Java in the foreground, but the inherited
LOG_APPENDERS=FILEdefault hides application startup and failure messages fromdocker logs. Users see Spring Boot banners without the old launcher's readiness messages.Set the Docker image default to
LOG_APPENDERS=FILE,CONSOLE. Startup messages such asportalContext [...] isActive: truebecome visible while file logging remains available. Document the readiness marker and shared log path in the English and Chinese README sections.demo.shand the Apollo JAR remain unchanged; users can still override the appender setting.Validation:
077, covering the new default and explicit override as well as PID 1, privilege dropping, graceful shutdown, and background zombie handling.docker logs, matching file logs, HTTP endpoints, and graceful stop.git diff --checkpassed.Image republication will follow maintainer confirmation. The Docker deployment guide is updated in apolloconfig/apollo#5689.