chore(mise): auto-install locked npm dependencies - #16
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, TOML syntax is valid, and it directly addresses the reported failure mode without introducing risky behavior.
Pull request overview
Adds a mise dependency provider so that running mise tasks (notably mise run dev) automatically installs Node dependencies from the lockfile, preventing “astro: not found” in fresh worktrees.
Changes:
- Introduces a
[deps.npm]configuration that runsnpm ci --no-audit --no-fundautomatically. - Uses
package-lock.jsonas the dependency source andnode_modules/.package-lock.jsonas the output marker for caching.
File summaries
| File | Description |
|---|---|
| .config/mise/conf.d/tasks-dev.toml | Adds an npm deps provider so mise tasks auto-install locked dependencies before running the dev task. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a mise deps provider so any mise task (including
mr dev) auto-installs locked npm dependencies frompackage-lock.jsonbefore running — fresh worktrees no longer fail withastro: not found.Verified by removing
node_modulesand runningmise run dev: mise deps installed 238 packages and Astro started successfully.Created by an agent via vekili.