chore(data): drop stale August 9 baseline JSON by vekilibot[bot] · Pull Request #17 · apphane-dev/eczane

vekilibot · 2026-09-09T17:57:01Z

Summary

Drops the committed stale baseline src/data/antalya.json (scraped 2026-08-09) and makes the site build without any committed data.

Both deploy workflows scrape fresh data before building, so the committed baseline is only a liability — it's exactly what shipped when a push deploy skipped the scraper (documented in deploy.yml: the 2026-09-09 regression to August data).

Changes

Delete src/data/antalya.json; git-ignore src/data/*.json (with .gitkeep) so a stale baseline can never be committed again
CityPage.astro resolves city data via import.meta.glob at build time; a fresh clone without scraped data builds into a localized empty state (new noData strings for tr/en/de/ru) instead of failing
README updated: deploy-time scraping is the norm, committed baselines are explicitly forbidden

Verification

npm run build with no data file: succeeds, renders the localized empty state, no pharmacy rows
npm run build after npm run scrape -- antalya: renders 39 pharmacies with a fresh last-updated timestamp

🤖 Generated by an agent (Codex) — opened via vekili as vekilibot[bot].

Summary by CodeRabbit

New Features
- City pages now load available data dynamically during builds.
- Added localized empty-state messages in Turkish, English, Russian, and German.
- Pages without available pharmacy data now show a clear, styled no-data message.
Bug Fixes
- Missing city data is handled gracefully instead of causing page errors.
Documentation
- Updated deployment and city setup guidance to reflect data generation during deployment.
Chores
- Generated data files are now excluded from version control; the previously committed Antalya dataset was removed.

Both deploy workflows scrape fresh data before building, so the committed src/data/antalya.json is only a liability: its Aug 9 snapshot is what shipped when a push deploy skipped the scraper (documented in deploy.yml). - delete src/data/antalya.json, git-ignore src/data/*.json so a stale baseline can never be committed again - CityPage resolves city data via import.meta.glob at build time; a fresh clone without scraped data builds into a localized empty state (noData strings for tr/en/de/ru) instead of failing - README: describe deploy-time scraping, drop baseline instructions Verified: build succeeds with no data file (empty state rendered, no pharmacy rows) and with scraped data (39 pharmacies + fresh timestamp).

Guria · 2026-09-09T18:00:59Z

@coderabbitai review

coderabbitai · 2026-09-09T18:01:16Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-09-09T18:01:26Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 3f441610-67e1-4bf7-8f4a-5358b604ebc9

📥 Commits

Reviewing files that changed from the base of the PR and between 3aae91e and 56ca968.

📒 Files selected for processing (7)

.gitignore
README.md
src/components/CityPage.astro
src/data/.gitkeep
src/data/antalya.json
src/lib/i18n.ts
src/styles/global.css

💤 Files with no reviewable changes (1)

src/data/antalya.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The deployment documentation now describes scrape-before-build behavior. The committed Antalya dataset is removed. CityPage dynamically loads available city JSON and renders an empty state when data is absent. Localized messages and styles support the new state.

Changes

Generated Data Handling

Layer / File(s)	Summary
Generated data deployment flow `.gitignore`, `README.md`, `src/data/antalya.json`	Generated city JSON is ignored. Deployment documentation describes scraping before building. The committed Antalya dataset is deleted.
Dynamic city data and empty state `src/components/CityPage.astro`, `src/lib/i18n.ts`, `src/styles/global.css`	`CityPage` resolves available JSON through `import.meta.glob`, handles missing data, passes an empty pharmacy list to `MapView`, and renders localized no-data text with matching styles.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 56ca9

This change removes stale committed city data and lets builds render a localized no-data state until fresh scraped data is available. The current implementation is ready to merge.

Sequence Diagram(s)

sequenceDiagram
  participant CityPage
  participant GlobData as import.meta.glob
  participant MapView
  participant I18n
  CityPage->>GlobData: resolve city JSON
  GlobData-->>CityPage: data or undefined
  CityPage->>I18n: read noData translation
  CityPage->>MapView: pass pharmacies or []
  CityPage-->>CityPage: render update time or no-data message

Suggested reviewers: guria

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the main change: removing the stale August 9 baseline JSON. It is concise and specific.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch t3code/remove-historical-august-9-data

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Copilot

🟢 Approval recommended

The changes align with the documented deploy workflows (both scrape before building) and the code now builds cleanly with or without local scraped JSON present.

Pull request overview

This PR removes the committed Antalya scrape baseline and updates the build to gracefully handle the absence of scraped data, relying on deploy-time scraping in GitHub Actions instead of repo-committed JSON.

Changes:

Deleted src/data/antalya.json and added src/data/*.json to .gitignore (keeping the directory tracked via .gitkeep).
Updated CityPage.astro to load scraped JSON via import.meta.glob at build time and render a localized empty state when data is missing.
Added localized noData strings and updated README guidance to explicitly forbid committed baselines.

File summaries

File	Description
src/styles/global.css	Adds styling for the new “no data” empty-state message.
src/lib/i18n.ts	Introduces `noData` string and provides translations for all locales.
src/data/antalya.json	Removes the stale committed baseline scrape data.
src/data/.gitkeep	Keeps `src/data/` tracked while ignoring generated JSON files.
src/components/CityPage.astro	Switches from static JSON import to build-time glob resolution + empty-state rendering.
README.md	Updates deployment documentation to reflect deploy-time scraping and forbid committed baselines.
.gitignore	Prevents future scraped JSON baselines from being committed.

Review details

Files reviewed: 5/7 changed files
Comments generated: 0
Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

vekilibot Bot changed the title ~~probe~~ chore(data): drop stale August 9 baseline JSON Sep 9, 2026

Guria requested a lite review from Copilot September 9, 2026 18:01

Copilot started reviewing on behalf of Guria September 9, 2026 18:02 View session

Copilot AI reviewed Sep 9, 2026

View reviewed changes

Guria merged commit cdd9bfd into main Sep 9, 2026
2 checks passed

Guria deleted the t3code/remove-historical-august-9-data branch September 9, 2026 18:33

vekilibot Bot mentioned this pull request Sep 9, 2026

chore(ci): drop stale baseline comment in update-data workflow #18

Merged

Navigation Menu

Uh oh!

chore(data): drop stale August 9 baseline JSON - #17

chore(data): drop stale August 9 baseline JSON#17
Guria merged 1 commit into
mainfrom
t3code/remove-historical-august-9-data

vekilibot Bot commented Sep 9, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

Guria commented Sep 9, 2026

Uh oh!

coderabbitai Bot commented Sep 9, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Sep 9, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

vekilibot Bot commented Sep 9, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Verification

Summary by CodeRabbit

Uh oh!

Guria commented Sep 9, 2026

Uh oh!

coderabbitai Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Sep 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vekilibot Bot commented Sep 9, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 9, 2026 •

edited

Loading

coderabbitai Bot commented Sep 9, 2026 •

edited

Loading