Scope the billing service account helper to the chart - #1323
Merged
Conversation
Installing the acaas umbrella failed with
ServiceAccount "default" in namespace "ace" exists and cannot be
imported into the current release: invalid ownership metadata
Helm keeps template definitions in one global namespace, and every acaas
subchart defines appscode.serviceAccountName. billing-ui, marketplace-api,
platform-links and website all define it as
{{- default "default" .Values.serviceAccount.name }}
so once any of them is enabled its body wins over billing's and the name
collapses to "default", which makes the chart try to adopt the namespace's
built-in service account. The collision was invisible while billing's own
body was identical; it only surfaced once the name started feeding a
ServiceAccount object and the role bindings.
Rename the define to billing.serviceAccountName, matching the chart-scoped
billing.fullname and billing.labels, and update the six call sites. With
the acaas values that reproduced the failure, billing now renders
acaas-billing for the service account, all three pod specs and all three
role bindings.
Signed-off-by: Imtiaz Uddin <imtiaz@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing the acaas umbrella failed with
ServiceAccount "default" in namespace "ace" exists and cannot be
imported into the current release: invalid ownership metadata
Helm keeps template definitions in one global namespace, and every acaas subchart defines appscode.serviceAccountName. billing-ui, marketplace-api, platform-links and website all define it as
{{- default "default" .Values.serviceAccount.name }}
so once any of them is enabled its body wins over billing's and the name collapses to "default", which makes the chart try to adopt the namespace's built-in service account. The collision was invisible while billing's own body was identical; it only surfaced once the name started feeding a ServiceAccount object and the role bindings.
Rename the define to billing.serviceAccountName, matching the chart-scoped billing.fullname and billing.labels, and update the six call sites. With the acaas values that reproduced the failure, billing now renders acaas-billing for the service account, all three pod specs and all three role bindings.