Add prom-label-proxy dnsNames for both ip and domain host types - #1324
Merged
Conversation
Signed-off-by: Arnob kumar saha <arnob@appscode.com>
Signed-off-by: Arnob kumar saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
prom-label-proxySANs were only emitted wheninfra.hostType=ip. Moved the block after both host-type branches so it applies in either mode;commonNamein the domain branch moved abovednsNamesso the shared block continues the list.Verified with
helm templatefor bothhostType=ipandhostType=domainin namespacemonitoring.Also bumps
go.bytebuilders.dev/catalogto v0.1.0 andkmodules.xyz/image-packer.