Repository navigation
Make toolkit imports granular and tree-shakeable - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Importing a small root export previously retained unrelated PnP registrations and inflated consumer bundles. Add canonical domain/narrow entrypoints and keep registration effects in the four feature-owning PnP services. Root, domain and preserved legacy leaf imports now produce identical production bundle sizes across nine fixture families.
Validation
Fresh local checks before this PR:
npm run build(library before app),npm run verify,npm run verify:package, andgit diff --check.Authenticated tenant checklist details and the full peer/browser matrix were not independently executed. Existing npm/SPFx metadata advisories remain visible. See
.docs/maintenance/2026-10-07-granular-tree-shaking-verification.mdfor measurements, provenance and evidence.Scrollbar follow-up
scrollbar.fluentnow uses 6px on both axes with 3px rounded thumb corners in Edge/Chrome, with Fluent colors, transparent tracks and native forced-colors fallback. Foreign Griffel width/color overrides keep their original composition precedence.Fresh verification passes: 676 tests, complete 36/18/9 package gates, and 477 sample + 967 engine observations in each of Edge154 and Chrome155. Both actual gutter dimensions are6px; computed thumb radius is3px. See
.docs/maintenance/2026-10-07-scrollbar-axes-fix.md.Scrollbar interaction restoration
Restored Fluent hover and pressed/dragged thumb colors, including pressed priority, release and mouse-leave feedback. Width/height remain6px and corners3px. Actual Edge/Chrome pointer tests and168 screenshot pixel checks pass in light, dark and high-contrast palettes;676 tests and all package gates pass. See
.docs/maintenance/2026-10-07-scrollbar-hover-fix.md.Actual SharePoint host theme correction
The real workbench host theme flattened base/hover/pressed scrollbar colors to the same v8 neutralSecondary token. Preserve the migration output except its two state tokens: map hover/pressed to host neutralPrimary/neutralDark. Real converter and host-provider regression tests now cover this path.
Verified in the user's authenticated Edge workbench after restarting the dev server: base#605e5c → hover#323130, pressed token#201f1e, still6px/radius3px. Actual native-window pixel checks confirm the hover change.676 tests and full package gates pass; no tenant writes or broad host-permission claims.