Add validated illumination correction worker - #172
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 155a53a525
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "P2_spearman": float(spearmanr(raw_sum[keep], corrected_sum[keep]).statistic), | ||
| "P2_applicable": True, |
There was a problem hiding this comment.
Mark undefined rank correlation as inapplicable
When at least ten detected objects have identical integrated intensities, spearmanr returns NaN even for the identity candidate because the rank vector is constant. This code nevertheless sets P2_applicable to true, so check_guardrails rejects the unchanged image and can report that every candidate is unsafe. Detect constant raw_sum or corrected_sum vectors and mark this metric inapplicable, as is already done when too few objects are measurable.
Useful? React with 👍 / 👎.
|
Superseded by PR 176: #176 |
Summary
Review fixes
A five-pass scientific/software review found and fixed same-plane model-selection leakage, the missing identity comparator, cross-acquisition model transfer, unsafe default per-tile gains, unscoped spot scoring, incomplete numeric guardrails, pre-cast-only validation, stale-setting edge cases, dependency gaps, and documentation/provenance drift.
Validation
./build_workers.sh --build-and-run-tests illumination_correction— 30 passed (including real BaSiC fits with darkfield off and on)docker compose config --quietpython3 -m py_compilefor worker and test modulesisGPUWorker=false,workerVersion=1.1.0pip checkreports only BaSiCPy's intentionally overridden stalescipy<1.13metadata pin; real fits pass against the worker base's newer SciPy stackContext
This is a fresh findings-based stitched-TIFF fallback and does not modify the older approach in #151. The documentation notes that the study's preferred workflow uses raw overlapping acquisition tiles when those data are available.