Repository navigation
#15 fix(confluence): Page through all attachments of a page - #16
Merged
Merged
Conversation
findChildAttachments() sent a single request and so returned at most 50 attachments (Confluence's default page size). It now requests pages of 200 and follows start/limit until a short page is returned.
sidler
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Content::findChildAttachments()sent a single request withoutstart/limit, so Confluence returned at most 50 attachments, and on pages with more the remaining images were never downloaded.startby thelimitConfluence actually applied, stopping on a short page (same approach asfindPagesInSpace()).ContentTestnow accepts multiple mocked responses and records sent requests; a new test covers paging across three result pages.Closes #15