Repository navigation
Fix receipt and callback digest split from a changing proposal - #340
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding and fix
A stateful JavaScript getter made
dispatchActionhash a first proposal for its receipt, then snapshot the caller object again and pass a different body to the host callback. The allow and approval-required local paths both returneddispatchedwith a receipt digest that did not identify the callback payload.The boundary now canonicalizes the caller once, validates the serialized value, and uses that same frozen proposal for planning, policy rechecks, approval, receipt, and callback.
Reproducible evidence
Verification
Focused Node and Python checks, 13-case cross-runtime comparison, local link and deployment checks pass. The broad local Node 24 suite has one pre-existing TypeScript fixture failure (
test/consumer-types.mts); GitHub CI uses Node 22.Limits: Project-authored local fixtures and selected mutations, no provider effect, outside witness, or formal proof of production safety.