Repository navigation
Enforce Ed25519 key type and canonical bytes for execution receipts - #361
Merged
aruintelligence merged 1 commit intoOct 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
signExecutionReceiptand refuse non-Ed25519 public keys inverifySignedExecutionReceipt, including legacy receipt signatures.Reproduction
Before this patch,
crypto.sign(null, ...)andcrypto.verify(null, ...)accepted RSA and EC keys while the receipt declaredalgorithm: "Ed25519". If a host pinned the RSA/EC fingerprint,applyLockedHttpDecisionentered its render callback. An otherwise valid Ed25519 receipt with!!!!appended to its base64 signature also reached the callback. After the change both paths block before rendering. This does not claim a bypass of a correctly pinned Ed25519 key.Checks
node --test: 801 passedAll examples are project-authored; they do not prove independent validation or production deployment fitness.