Repository navigation
Conversation
(cherry picked from commit 854b57c) Reported-by: Bizuayeu <ashhart#636 (comment)> (cherry picked from commit 88418d8)
(cherry picked from commit 602a0fd) Reported-by: Bizuayeu <ashhart#636 (comment)> (cherry picked from commit 4c69b0d)
jayleaton
marked this pull request as ready for review
October 20, 2026 20:04
Owner
|
Thank you for carrying this from #636. It is on main as 094a090, with @cwschroeder as author and you as co-author: tf-tp-test parses its whole command before it reads configuration or opens a driver, bootstrap or fate channel, and a malformed command exits 2 with the usage line. On our side the build hooks keep the release branch's Windows guard for the POSIX socket suite, and your 18 entry-point controls run in the Linux test set. It ships with the next release. Closing as landed. - Synthema, Ash's AI Assistant. |
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
tf-tp-testparses its whole command before it reads any configuration or opens a driver, bootstrap or fate channel. A malformed command exits 2 with the usage line and takes no resource.This is the first of three carries from #636, as asked in its closing comment (#636 (comment)): the command parser and its invalid-command controls, from @cwschroeder's series (88418d8, 4c69b0d). Both commits keep @cwschroeder as author, with
-xprovenance and theReported-by: Bizuayeutrailer.zig/src/fabric/tp/gpu_cli.zig(new): the command grammar, its unit tests, and theinvalidtable of malformed commands.zig/src/fabric/tp/gpu_main.zig: dispatches on the parsed command. The failfast host-only refusal,kernel,roce-hostandhcabehave as before.zig/build/tp.zig:test-tp-cliruns the parser's tests on every host. On a native Linux build, everyinvalidcommand runstf-tp-testwithTF_TP_WORLD=invalid. Each must exit 2 and print exactly the usage line, which proves the command is refused before configuration. Without an embedded mailbox kernel,kernelmust exit 1 and printmailbox kernel 0 B.test-tpdepends ontest-tp-cli.Adaptation onto main:
build/tp.zigkeeps main's portabletest-tpand Linux compile check. The CLI step sits beside them, and every negative control is kept.Receipt
ubuntu-latestzig,windows-latestzig-windows), Zig 0.17.0, based1018b31.zig build test(results in this PR's checks).Checklist