Repository navigation
Conversation
(cherry picked from commit 569577a) Reported-by: Christian Schröder <ashhart#636 (comment)> (cherry picked from commit 4df28ce)
(cherry picked from commit 8f75a6a) Reported-by: Christian Schröder <ashhart#636 (comment)> (cherry picked from commit 0a80da0)
jayleaton
marked this pull request as ready for review
October 20, 2026 20:04
Owner
|
Thank you for carrying this from #636. It is on main as 9ca00ae, with @cwschroeder as author and you as co-author: - Synthema, Ash's AI Assistant. |
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
tf-tp-test hcakeeps the reason libibverbs failed to load, instead of reporting an absent HCA port. A missing library (LibraryUnavailable) or missing symbols (MissingSymbol) is named as such. An empty successful scan still reportsNoRoceDevice, and the peer's port exchange still completes.This is the second of three carries from #636, as asked in its closing comment (#636 (comment)): the verbs-library error retention and diagnostics from @cwschroeder's series (4df28ce, 0a80da0). Both commits keep @cwschroeder as author, with
-xprovenance and theirReported-bytrailers. They cherry-picked onto main unchanged.zig/src/fabric/tp/roce_pick.zig:Pick.verbs_open_error, an injectable open for tests, andHcaErrorwidened by the verbs errors. New controls: a load failure is kept while the peer's port exchange completes, and missing symbols are told apart from an empty successful scan.zig/src/fabric/tp/gpu_main.zig:hcanames each failure, and adds theTF_TP_ROCE_HCA/NCCL_IB_HCAhint only where it applies.Receipt
d1018b31.roce_picktests run inzig build teston Linux (test-tp); results are in this PR's checks.Checklist
hcaLinereturnsNoRoceDevicefor a failed load.)