Improve PrinterFarm reliability and batch uploads - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root causes
Creality printers can report fragmented or delayed telemetry, and their status socket tolerates few simultaneous connections. PrinterFarm trusted the percentage field even when layer counters advanced, scanned each address only once with a timeout shorter than observed printer response times, allowed discovery and polling to contend for the same socket, and preserved stale online telemetry after complete network failures. The upload picker also consumed only the first selected file, and an idle firmware state was treated as proof that the physical bed was empty.
Impact
Printer progress, discovery counts, offline state, bed-clearance safety, and batch queueing now behave consistently with the real four-printer hotspot setup.
Validation
npm run check