Fix/issue 7 scsi check condition request sense - #42
ashishsinghbora merged 2 commits into
Conversation
- Explicitly detect SCSI CHECK CONDITION from CSW (status == Status.FAILED) - Automatically issue SCSI REQUEST SENSE (opcode 0x03) without recursive error handling - Robustly parse fixed (0x70/0x71) and descriptor (0x72/0x73) sense data - Map standard SCSI sense keys, ASC, and ASCQ to human-readable structured representations - Provide ScsiCheckConditionException and ScsiCommandResult for rich caller diagnostics - Retain backward compatibility while adding throwing variants (readBlocksOrThrow, writeBlocksOrThrow, writeDirectBufferOrThrow) - Add 21 unit tests (ScsiSenseParserTest, ScsiCheckConditionTest) with mock and simulated BOT tests - Update documentation and claims auditor to reflect 185 total test methods (184 unit)
…k-condition-request-sense
Up to standards ✅🟢 Issues
|
![codacy-production[bot]](https://avatars.githubusercontent.com/in/56611?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull Request Overview
This Pull Request is currently missing implementation details and code changes. While the title indicates it aims to address SCSI status handling, the diff is empty, and the PR description remains a default template. Furthermore, none of the defined acceptance criteria—such as triggering 'Request Sense' or parsing Sense Data—can be verified. The Codacy analysis reports missing requirements for coverage, which is expected given the lack of changes.
About this PR
- This Pull Request contains no code changes. Please ensure the intended commits have been pushed and are included in the branch associated with this PR.
- The PR description uses a default template and the verification checklist is entirely unchecked. Please provide a link to the relevant issue and details on how the implementation was tested.
Test suggestions
- Verify that receiving a CHECK CONDITION (0x02) status triggers a REQUEST SENSE command
- Verify that Sense Data is correctly extracted and mapped to internal error codes
Prompt proposal for missing tests
Consider implementing these tests if applicable:
1. Verify that receiving a CHECK CONDITION (0x02) status triggers a REQUEST SENSE command
2. Verify that Sense Data is correctly extracted and mapped to internal error codes
TIP Improve review quality by adding custom instructions
TIP How was this review? Give us feedback
2 participants
📌 Description
Fixes #(issue)
🏛️ Architectural Layer Impacted
app/src/main/java/.../ui,service)flasher)linux,windows,ventoy)iso,fat32)gpt,mbr)BlockDevice, mock devices)scsi,usb, BOT driver)🧪 Verification & Quality Checklist
./gradlew lintpasses with 0 errors../gradlew testpasses 100% of unit tests../gradlew assembleDebugcompiles cleanly.BlockDeviceabstractions for modified logic.README.md,ARCHITECTURE.md,LIMITATIONS.md).🔌 Real Hardware Testing (Optional but Strongly Encouraged)