Skip to content

fix(packages): use arrays for package commands, add dry-run, and support apk - #28

Merged
ashishsinghbora merged 1 commit into
mainfrom
fix/package-manager-execution
Sep 24, 2026
Merged

ashishsinghbora merged 1 commit into
mainfrom
fix/package-manager-execution

Conversation

@ashishsinghbora

Copy link
Copy Markdown
Owner

Summary

  • Replaced word-split string commands with Bash arrays (${CMD[@]}) in install-package.sh and remove-package.sh to prevent execution failure on multi-argument commands like pacman -S --noconfirm.
  • Added -n / --dry-run option across package manager utilities.
  • Added Alpine Linux (apk) support across all scripts/packages/ scripts.
  • Fixed package-info.sh pacman query to fall back to pacman -Si when package is not installed locally.
  • Fixed environment variable shadowing of TERM in search-package.sh.

Verification

  • Verified with unit tests mocking pacman, apt, dnf, zypper, and apk in an isolated PATH environment.
  • Verified ShellCheck passes without warnings.
  • Verified test suite passes.

@ashishsinghbora ashishsinghbora left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: verified array execution prevents word splitting on package commands, added dry-run options, supported apk, and tested with mock binaries across 5 package managers.

@ashishsinghbora
ashishsinghbora merged commit b21b465 into main Sep 24, 2026
1 check passed
@ashishsinghbora
ashishsinghbora deleted the fix/package-manager-execution branch September 24, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant