Skip to content

Add testing of s3 upload functionality #47

Description

@jlizen

This came up in: #46

We don't really have any meaningful tests of s3 uploading functionality, or the aws functionality more general - just metadata parsing.

This forces manual validation when we make changes that touch on relevant code paths.

I see two main options:

  • add unit tests using aws-smithy-mocks and keep doing manual e2e validation on significant changes as well
  • add real e2e integration tests that we run using github CI against a real aws account, etc

I wouldn't say this is urgent, but will remain a paper cut until we automate something.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions