fix: safely alias schema properties and transform root xml to x-xml - #335
Open
RohithPariki wants to merge 1 commit into
Open
fix: safely alias schema properties and transform root xml to x-xml#335RohithPariki wants to merge 1 commit into
RohithPariki wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
RohithPariki
marked this pull request as ready for review
August 29, 2026 02:07
RohithPariki
requested review from
AayushSaini101,
asyncapi-bot-eve and
princerajpoot20
as code owners
August 29, 2026 02:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR improves the schema traversal safety in
iterateSchemaandaliasPropswithin@asyncapi/openapi-schema-parser:null, or boolean schema values initerateSchemaandaliasProps. Previously, properties with primitive values, boolean schemas (e.g.,additionalProperties: false, boolean items), ornullvalues could causeTypeErrorwhen attempting property lookups.xmltox-xmlon top-level root schema objects in addition to nested properties.Changes Made
iterateSchemaandaliasPropsinsrc/index.ts.xmltox-xmlaliasing initerateSchema.test/parser.spec.ts.Checks
npm testpasses (9/9 tests pass) with 98.27% code coverage.npm run lintpasses with 0 warnings/errors.npm run buildsucceeds (both ESM and CJS).