fix: use 'where' instead of 'which' on Windows for devcontainer CLI detection - #124
fix: use 'where' instead of 'which' on Windows for devcontainer CLI detection#124SabotageAndi wants to merge 1 commit into
Conversation
…etection Agent-Logs-Url: https://github.com/SabotageAndi/opencode-devcontainers/sessions/5b384e1f-928d-4e7a-b6fc-7598f15398ca Co-authored-by: SabotageAndi <859801+SabotageAndi@users.noreply.github.com>
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe devcontainer CLI check now uses ChangesDevcontainer CLI detection
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Hi @SabotageAndi — thank you so much for taking the time to investigate and fix this Windows I'm going to close this PR in favor of #130, which addresses the same bug from issue #123 but also adds test coverage to prevent regressions. Since both PRs fix the same underlying issue, I want to avoid merging two overlapping changes. Your work here was genuinely appreciated and helped validate the fix direction. Thanks again for contributing! 🙏 |
fixes #123
Summary by CodeRabbit