Skip to content

fix: use 'where' instead of 'which' on Windows for devcontainer CLI detection - #124

Closed
SabotageAndi wants to merge 1 commit into
athal7:mainfrom
SabotageAndi:fix/issue-123-which-on-windows
Closed

fix: use 'where' instead of 'which' on Windows for devcontainer CLI detection#124
SabotageAndi wants to merge 1 commit into
athal7:mainfrom
SabotageAndi:fix/issue-123-which-on-windows

Conversation

@SabotageAndi

@SabotageAndi SabotageAndi commented Apr 22, 2026

Copy link
Copy Markdown

fixes #123

Summary by CodeRabbit

  • Bug Fixes
    • Improved detection of the Dev Container CLI across Windows and non-Windows platforms.

@athal7

athal7 commented Jul 17, 2026

Copy link
Copy Markdown
Owner

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 985125f5-b53b-4b2f-a97b-180f6815f187

📥 Commits

Reviewing files that changed from the base of the PR and between 670b438 and 3530ef2.

📒 Files selected for processing (1)
  • plugin/core/devcontainer.js

📝 Walkthrough

Walkthrough

The devcontainer CLI check now uses where on Windows and which on other platforms, preserving the existing detection flow and return behavior.

Changes

Devcontainer CLI detection

Layer / File(s) Summary
Platform command selection
plugin/core/devcontainer.js
checkDevcontainerCli() selects the platform-appropriate command before checking whether devcontainer is installed.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: using where on Windows for devcontainer CLI detection.
Linked Issues check ✅ Passed The change satisfies issue #123 by replacing Windows which with where to detect the devcontainers CLI.
Out of Scope Changes check ✅ Passed The diff is narrowly scoped to Windows CLI detection and introduces no unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@athal7

athal7 commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Hi @SabotageAndi — thank you so much for taking the time to investigate and fix this Windows whichwhere detection issue! Your contribution was really helpful in surfacing the problem.

I'm going to close this PR in favor of #130, which addresses the same bug from issue #123 but also adds test coverage to prevent regressions. Since both PRs fix the same underlying issue, I want to avoid merging two overlapping changes.

Your work here was genuinely appreciated and helped validate the fix direction. Thanks again for contributing! 🙏

@athal7 athal7 closed this Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

which not available on windows - devcontainers cli never found

3 participants